Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: test config updates #1108

Merged
merged 1 commit into from
Sep 12, 2020
Merged

build: test config updates #1108

merged 1 commit into from
Sep 12, 2020

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Sep 12, 2020

This makes a couple small tweaks to our test configuration:

  1. mocha will now find test files recursively.
  2. npm will fail if an attempt is made to install a dependency that is not supported by our engines field.

@bcoe bcoe requested review from a team as code owners September 12, 2020 00:23
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 12, 2020
feywind
feywind approved these changes Sep 12, 2020
View reviewed changes
Copy link
Collaborator

@feywind feywind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 12, 2020 •
edited
Loading

Codecov Report

Merging #1108 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1108   +/-   ##
=======================================
  Coverage   97.78%   97.78%           
=======================================
  Files          25       25           
  Lines       11067    11068    +1     
  Branches      546      595   +49     
=======================================
+ Hits        10822    10823    +1     
  Misses        241      241           
  Partials        4        4
Impacted Files Coverage Δ
.mocharc.js 79.31% <100.00%> (+0.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9c33fd...cef9c25. Read the comment docs.

@bcoe bcoe added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 12, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 12, 2020
@bcoe bcoe merged commit a8c4aa0 into master Sep 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feywind feywind feywind approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bcoe @feywind @yoshi-kokoro