Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ts): create generic for object streams #101

Merged
merged 2 commits into from
Mar 8, 2019
Merged

refactor(ts): create generic for object streams #101

merged 2 commits into from
Mar 8, 2019

Conversation

callmehiphop
Copy link
Contributor

@callmehiphop callmehiphop commented Mar 8, 2019 •
edited
Loading

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 8, 2019
@codecov
Copy link

codecov bot commented Mar 8, 2019 •
edited
Loading

Codecov Report

Merging #101 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #101   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          87     87           
  Branches       10     10           
=====================================
  Hits           87     87
Impacted Files Coverage Δ
src/index.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de1bdc0...d71788a. Read the comment docs.

JustinBeckwith
JustinBeckwith reviewed Mar 8, 2019
View reviewed changes
src/index.ts Outdated Show resolved Hide resolved
@JustinBeckwith JustinBeckwith merged commit cba775d into googleapis:master Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

@stephenplusplus stephenplusplus Awaiting requested review from stephenplusplus

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@callmehiphop @JustinBeckwith @googlebot