Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cache detected environment's default resource #359

Merged
merged 2 commits into from
Jan 2, 2019
Merged

feat: cache detected environment's default resource #359

merged 2 commits into from
Jan 2, 2019

Conversation

stephenplusplus
Copy link
Contributor

Fixes #353

This will cache the environment's default resource, instead of pinging for it on every log.write() request.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 2, 2019
@stephenplusplus stephenplusplus mentioned this pull request Jan 2, 2019
Closed
@JustinBeckwith JustinBeckwith merged commit 6cf18aa into googleapis:master Jan 2, 2019
@wyardley
Copy link

wyardley commented Jan 3, 2019

Thanks for getting this knocked out, and for cutting the release @stephenplusplus @JustinBeckwith

Did a quick test in the POC I was using to verify this behavior, and looks good so far!

@snyk-bot snyk-bot mentioned this pull request Mar 1, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

@callmehiphop callmehiphop Awaiting requested review from callmehiphop

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stephenplusplus @wyardley @JustinBeckwith @googlebot