This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
fix(browser): check for fetch on window #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autosynth cannot find the source of changes triggered by earlier changes in this
repository, or by version upgrades to tools such as linters.
…d jsdoc comments with examples build: use gapic-generator-typescript v1.2.1 Note: these change require google-gax "^2.9.2". @alexander-fenster will make sure the google-gax version is bumped across libraries. PiperOrigin-RevId: 341102751 Source-Author: Google APIs <[email protected]> Source-Date: Fri Nov 6 12:56:54 2020 -0800 Source-Repo: googleapis/googleapis Source-Sha: b759c563bacf9cd15749be4d2bdd276d3f48ee29 Source-Link: googleapis/googleapis@b759c56
Use gapic-generator-typescript v1.2.2. PiperOrigin-RevId: 342778480 Source-Author: Google APIs <[email protected]> Source-Date: Mon Nov 16 20:22:00 2020 -0800 Source-Repo: googleapis/googleapis Source-Sha: c6b1c72942991b1c605fe56a6041e06a86a9443e Source-Link: googleapis/googleapis@c6b1c72
Use gapic-generator-typescript v1.2.3. PiperOrigin-RevId: 342976840 Source-Author: Google APIs <[email protected]> Source-Date: Tue Nov 17 17:04:11 2020 -0800 Source-Repo: googleapis/googleapis Source-Sha: c979fbeb80d1b940790a69183629d799e4c05b4c Source-Link: googleapis/googleapis@c979fbe
Use gapic-generator-typescript v1.2.4. Committer: @alexander-fenster PiperOrigin-RevId: 343136730 Source-Author: Google APIs <[email protected]> Source-Date: Wed Nov 18 12:49:25 2020 -0800 Source-Repo: googleapis/googleapis Source-Sha: 2cda8d285b66c14da57363201b7e4efbca47d034 Source-Link: googleapis/googleapis@2cda8d2
Use gapic-generator-typescript v1.2.5. Committer: @alexander-fenster PiperOrigin-RevId: 343187793 Source-Author: Google APIs <[email protected]> Source-Date: Wed Nov 18 17:10:02 2020 -0800 Source-Repo: googleapis/googleapis Source-Sha: 5587028631d4d743fd906c4eb4e4e4649a7ee5ce Source-Link: googleapis/googleapis@5587028
product-auto-label
bot
added
the
api: cloudkms
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #404 +/- ##
==========================================
- Coverage 97.95% 97.93% -0.03%
==========================================
Files 5 5
Lines 3910 3918 +8
Branches 125 126 +1
==========================================
+ Hits 3830 3837 +7
- Misses 79 80 +1
Partials 1 1
Continue to review full report at Codecov.
|
bcoe
changed the title
bcoe
approved these changes
Nov 23, 2020
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Dec 2, 2020
🤖 I have created a release \*beep\* \*boop\* --- ### [2.1.4](https://github.com/googleapis/nodejs-kms/compare/v2.1.3...v2.1.4) (2020-11-25) ### Bug Fixes * **browser:** check for fetch on window ([#404](https://github.com/googleapis/nodejs-kms/issues/404)) ([96a90e3](https://github.com/googleapis/nodejs-kms/commit/96a90e3bea1c8b7e8e2d57cc1eb6204ed326b915)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was generated using Autosynth. 🌈
Synth log will be available here:
https://source.cloud.google.com/results/invocations/edf6e1db-1123-48a0-b999-6e126b11939a/targets
PiperOrigin-RevId: 343187793
Source-Link: googleapis/googleapis@5587028
PiperOrigin-RevId: 343136730
Source-Link: googleapis/googleapis@2cda8d2
PiperOrigin-RevId: 342976840
Source-Link: googleapis/googleapis@c979fbe
PiperOrigin-RevId: 342778480
Source-Link: googleapis/googleapis@c6b1c72
PiperOrigin-RevId: 341102751
Source-Link: googleapis/googleapis@b759c56