Skip to content
This repository was archived by the owner on Dec 19, 2023. It is now read-only.

feat: support apiEndpoint overrides #272

Merged
merged 2 commits into from
May 31, 2019
Merged

feat: support apiEndpoint overrides #272

merged 2 commits into from
May 31, 2019

Conversation

JustinBeckwith
Copy link
Contributor

Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for discussion)

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 29, 2019
@JustinBeckwith JustinBeckwith requested a review from bcoe May 29, 2019 22:18
@codecov
Copy link

codecov bot commented May 29, 2019

Codecov Report

Merging #272 into master will increase coverage by 0.03%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #272      +/-   ##
==========================================
+ Coverage   92.62%   92.65%   +0.03%     
==========================================
  Files           4        4              
  Lines         244      245       +1     
  Branches       47       47              
==========================================
+ Hits          226      227       +1     
- Misses          8        9       +1     
+ Partials       10        9       -1
Impacted Files Coverage Δ
src/index.ts 97.82% <50%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cfb3cb...06cb8ef. Read the comment docs.

Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is looking reasonable to me 👍

test/index.ts Outdated
apiEndpoint,
});
const calledWith = dns.calledWith_[0];
console.log(calledWith);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

console.log kicking around.

@JustinBeckwith JustinBeckwith merged commit 2c42f20 into master May 31, 2019
@stephenplusplus stephenplusplus deleted the apiendpoint branch May 31, 2019 21:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants