This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
tests: tests required for alpha #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: compute
google-cla
bot
added
the
cla: yes
|
@alexander-fenster please take a look |
gcf-owl-bot
bot
removed
the
owlbot:run
bcoe
approved these changes
Jul 8, 2021
| @@ -211,6 +211,46 @@ describe('Compute', () => { | |||
| }); | |||
| assert.strictEqual(fetched.shieldedInstanceConfig.enableSecureBoot, true); | |||
| }); | |||
|
|
|||
| it('API errors propagated', async () => { | |||
There was a problem hiding this comment.
nit: I like for the assertions to read like a phrase.
it('propagates API errors').
| instance: INSTANCE_NAME, | ||
| instanceResource: instance, | ||
| }); | ||
| await waitZonalOperation(updateOp); |
There was a problem hiding this comment.
I like the use of async/await in tests 👍
bcoe
approved these changes
Jul 8, 2021
There was a problem hiding this comment.
I should say, LGTM, with @summer-ji-eng or @alexander-fenster's approval.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕