fix: destroy internal grpc conn when closed (#439)

googleapis · Apr 15, 2024 · e7731bf · e7731bf
1 parent f555322
commit e7731bf
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/src/managedwriter/stream_connection.ts b/src/managedwriter/stream_connection.ts
@@ -327,6 +327,7 @@ export class StreamConnection extends EventEmitter {
     }
     this._connection.end();
     this._connection.removeAllListeners();
+    this._connection.destroy();
     this._connection = null;
   }
 

diff --git a/system-test/managed_writer_client_test.ts b/system-test/managed_writer_client_test.ts
@@ -1269,6 +1269,7 @@ describe('managedwriter.WriterClient', () => {
           destinationTable: parent,
         });
         const connection = await client.createStreamConnection({streamId});
+        const internalConn = connection['_connection']!;
         const writer = new Writer({
           connection,
           protoDescriptor,
@@ -1284,6 +1285,7 @@ describe('managedwriter.WriterClient', () => {
         writer.close();
         client.close();
         assert.strictEqual(client.isOpen(), false);
+        assert.strictEqual(internalConn.destroyed, true);
       } finally {
         client.close();
       }