Skip to content

Commit

Permalink
docs: change samples on exclusive stream to explicitly create them (#449
Browse files Browse the repository at this point in the history
)
  • Loading branch information
alvarowolfx authored May 6, 2024
1 parent 367e934 commit 841de04
Show file tree
Hide file tree
Showing 5 changed files with 20 additions and 14 deletions.
8 changes: 5 additions & 3 deletions samples/append_rows_buffered.js
Original file line number Diff line number Diff line change
Expand Up @@ -49,14 +49,16 @@ function main(
'root'
);

const connection = await writeClient.createStreamConnection({
const streamId = await writeClient.createWriteStream({
streamType,
destinationTable,
});

const streamId = connection.getStreamId();
console.log(`Stream created: ${streamId}`);

const connection = await writeClient.createStreamConnection({
streamId,
});

const writer = new JSONWriter({
streamId,
connection,
Expand Down
8 changes: 5 additions & 3 deletions samples/append_rows_json_writer_commited.js
Original file line number Diff line number Diff line change
Expand Up @@ -49,14 +49,16 @@ function main(
'root'
);

const connection = await writeClient.createStreamConnection({
const streamId = await writeClient.createWriteStream({
streamType,
destinationTable,
});

const streamId = connection.getStreamId();
console.log(`Stream created: ${streamId}`);

const connection = await writeClient.createStreamConnection({
streamId,
});

const writer = new JSONWriter({
streamId,
connection,
Expand Down
1 change: 0 additions & 1 deletion samples/append_rows_pending.js
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ function main(
});
console.log(`Stream created: ${streamId}`);

// Append data to the given stream.
const connection = await writeClient.createStreamConnection({
streamId,
});
Expand Down
9 changes: 5 additions & 4 deletions samples/append_rows_proto2.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,15 +56,16 @@ function main(
const writeClient = new WriterClient({projectId});

try {
// Append data to the given stream.
const connection = await writeClient.createStreamConnection({
const streamId = await writeClient.createWriteStream({
streamType,
destinationTable,
});

const streamId = connection.getStreamId();
console.log(`Stream created: ${streamId}`);

const connection = await writeClient.createStreamConnection({
streamId,
});

const writer = new Writer({
connection,
protoDescriptor,
Expand Down
8 changes: 5 additions & 3 deletions samples/append_rows_table_to_proto2.js
Original file line number Diff line number Diff line change
Expand Up @@ -49,14 +49,16 @@ function main(
'root'
);

const connection = await writeClient.createStreamConnection({
const streamId = await writeClient.createWriteStream({
streamType,
destinationTable,
});

const streamId = connection.getStreamId();
console.log(`Stream created: ${streamId}`);

const connection = await writeClient.createStreamConnection({
streamId,
});

const writer = new JSONWriter({
connection,
protoDescriptor,
Expand Down

0 comments on commit 841de04

Please sign in to comment.