Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

fix: do not modify options object, use defaultScopes #419

Merged
merged 4 commits into from
Nov 11, 2020
Merged

Conversation

alexander-fenster
Copy link
Contributor

Regenerated the library using
gapic-generator-typescript
v1.2.1.

@alexander-fenster alexander-fenster requested a review from a team as a code owner November 6, 2020 22:21
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 6, 2020
@product-auto-label product-auto-label bot added the api: cloudasset Issues related to the googleapis/nodejs-asset API. label Nov 6, 2020
@alexander-fenster alexander-fenster added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 6, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 6, 2020
@bcoe bcoe added the automerge Merge the pull request once unit tests and other checks pass. label Nov 6, 2020
@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

1 similar comment
@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 7, 2020
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@bcoe bcoe reopened this Nov 10, 2020
@codecov
Copy link

codecov bot commented Nov 10, 2020

Codecov Report

Merging #419 (46d7ffd) into master (9a82345) will decrease coverage by 0.04%.
The diff coverage is 96.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #419      +/-   ##
==========================================
- Coverage   96.96%   96.92%   -0.05%     
==========================================
  Files          15       15              
  Lines        5841     5946     +105     
  Branches      273      255      -18     
==========================================
+ Hits         5664     5763      +99     
- Misses        171      177       +6     
  Partials        6        6              
Impacted Files Coverage Δ
src/v1beta1/asset_service_client.ts 96.29% <94.82%> (-0.08%) ⬇️
src/v1p4beta1/asset_service_client.ts 96.06% <94.82%> (-0.08%) ⬇️
src/v1p2beta1/asset_service_client.ts 96.96% <95.08%> (-0.04%) ⬇️
src/v1p5beta1/asset_service_client.ts 95.25% <95.38%> (-0.16%) ⬇️
src/v1p1beta1/asset_service_client.ts 96.28% <96.80%> (-0.11%) ⬇️
src/v1/asset_service_client.ts 98.70% <98.15%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a82345...46d7ffd. Read the comment docs.

@sofisl sofisl merged commit 790ffd3 into master Nov 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: cloudasset Issues related to the googleapis/nodejs-asset API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants