Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reset default to platform thread #3551

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

olavloite
Copy link
Collaborator

Reset the default to using a platform thread for connections. This was the default before adding an option for setting the executor type, and the new default is causing problems with the async Connection API.

Fixes #3541

Reset the default to using a platform thread for connections. This was the
default before adding an option for setting the executor type, and the new
default is causing problems with the async Connection API.

Fixes #3541
@olavloite olavloite requested a review from a team as a code owner December 13, 2024 16:17
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: spanner Issues related to the googleapis/java-spanner API. labels Dec 13, 2024
@olavloite olavloite merged commit c2d5614 into main Dec 13, 2024
34 checks passed
@olavloite olavloite deleted the use-platform-thread-by-default branch December 13, 2024 16:46
surbhigarg92 pushed a commit to surbhigarg92/java-spanner that referenced this pull request Dec 26, 2024
Reset the default to using a platform thread for connections. This was the
default before adding an option for setting the executor type, and the new
default is causing problems with the async Connection API.

Fixes googleapis#3541
gagangupt16 pushed a commit to gagangupt16/java-spanner that referenced this pull request Dec 27, 2024
Reset the default to using a platform thread for connections. This was the
default before adding an option for setting the executor type, and the new
default is causing problems with the async Connection API.

Fixes googleapis#3541
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spanner.connection.it.ITAsyncTransactionRetryTest: testRetryHighAbortRate failed
1 participant