Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: append gRPC error message for debugging #3345

Merged
merged 2 commits into from
Sep 25, 2024
Merged

chore: append gRPC error message for debugging #3345

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d301dd1
chore: append gRPC error message for debugging
harshachinta Sep 24, 2024
7eb846a
fix: lint
harshachinta Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 25 additions & 16 deletions ...cloud-spanner-executor/src/main/java/com/google/cloud/executor/spanner/CloudExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,39 +416,48 @@ public Status sendOutcome(SpannerActionOutcome outcome) {

/** Map Cloud ErrorCode to Status. */
protected Status toStatus(SpannerException e) {
String errorMessage = e.getMessage();
com.google.rpc.Status rpcStatus = io.grpc.protobuf.StatusProto.fromThrowable(e);
if (rpcStatus != null) {
if (rpcStatus.getDetailsCount() > 0) {
errorMessage += "/n";
}
for (int i = 0; i < rpcStatus.getDetailsCount(); i++) {
errorMessage += "\nError detail: " + rpcStatus.getDetails(i).toString();
}
}
switch (e.getErrorCode()) {
case INVALID_ARGUMENT:
return Status.fromCode(Status.INVALID_ARGUMENT.getCode()).withDescription(e.getMessage());
return Status.fromCode(Status.INVALID_ARGUMENT.getCode()).withDescription(errorMessage);
case PERMISSION_DENIED:
return Status.fromCode(Status.PERMISSION_DENIED.getCode()).withDescription(e.getMessage());
return Status.fromCode(Status.PERMISSION_DENIED.getCode()).withDescription(errorMessage);
case ABORTED:
return Status.fromCode(Status.ABORTED.getCode()).withDescription(e.getMessage());
return Status.fromCode(Status.ABORTED.getCode()).withDescription(errorMessage);
case ALREADY_EXISTS:
return Status.fromCode(Status.ALREADY_EXISTS.getCode()).withDescription(e.getMessage());
return Status.fromCode(Status.ALREADY_EXISTS.getCode()).withDescription(errorMessage);
case CANCELLED:
return Status.fromCode(Status.CANCELLED.getCode()).withDescription(e.getMessage());
return Status.fromCode(Status.CANCELLED.getCode()).withDescription(errorMessage);
case INTERNAL:
return Status.fromCode(Status.INTERNAL.getCode())
.withDescription(e.getMessage() + e.getReason() == null ? "" : ": " + e.getReason());
.withDescription(errorMessage + e.getReason() == null ? "" : ": " + e.getReason());
case FAILED_PRECONDITION:
return Status.fromCode(Status.FAILED_PRECONDITION.getCode())
.withDescription(e.getMessage());
return Status.fromCode(Status.FAILED_PRECONDITION.getCode()).withDescription(errorMessage);
case NOT_FOUND:
return Status.fromCode(Status.NOT_FOUND.getCode()).withDescription(e.getMessage());
return Status.fromCode(Status.NOT_FOUND.getCode()).withDescription(errorMessage);
case DEADLINE_EXCEEDED:
return Status.fromCode(Status.DEADLINE_EXCEEDED.getCode()).withDescription(e.getMessage());
return Status.fromCode(Status.DEADLINE_EXCEEDED.getCode()).withDescription(errorMessage);
case RESOURCE_EXHAUSTED:
return Status.fromCode(Status.RESOURCE_EXHAUSTED.getCode()).withDescription(e.getMessage());
return Status.fromCode(Status.RESOURCE_EXHAUSTED.getCode()).withDescription(errorMessage);
case OUT_OF_RANGE:
return Status.fromCode(Status.OUT_OF_RANGE.getCode()).withDescription(e.getMessage());
return Status.fromCode(Status.OUT_OF_RANGE.getCode()).withDescription(errorMessage);
case UNAUTHENTICATED:
return Status.fromCode(Status.UNAUTHENTICATED.getCode()).withDescription(e.getMessage());
return Status.fromCode(Status.UNAUTHENTICATED.getCode()).withDescription(errorMessage);
case UNIMPLEMENTED:
return Status.fromCode(Status.UNIMPLEMENTED.getCode()).withDescription(e.getMessage());
return Status.fromCode(Status.UNIMPLEMENTED.getCode()).withDescription(errorMessage);
case UNAVAILABLE:
return Status.fromCode(Status.UNAVAILABLE.getCode()).withDescription(e.getMessage());
return Status.fromCode(Status.UNAVAILABLE.getCode()).withDescription(errorMessage);
case UNKNOWN:
return Status.fromCode(Status.UNKNOWN.getCode()).withDescription(e.getMessage());
return Status.fromCode(Status.UNKNOWN.getCode()).withDescription(errorMessage);
default:
return Status.fromCode(Status.UNKNOWN.getCode())
.withDescription("Unsupported Spanner error code: " + e.getErrorCode());
Expand Down
Loading