Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix the queryAndThen method in the mock test server #2623

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

olavloite
Copy link
Collaborator

The mock server that is used for testing contained a queryAndThen(..) method that did not do anything with the 'and then' part. This PR fixes that, and adds an additional test using that method. That test shows what happens with a bit-reversed sequence when a transaction is aborted.

The mock server that is used for testing contained a queryAndThen(..)
method that did not do anything with the 'and then' part. This PR fixes
that, and adds an additional test using that method. That test shows
what happens with a bit-reversed sequence when a transaction is aborted.
@olavloite olavloite requested review from manu2 and arpan14 September 13, 2023 14:29
@olavloite olavloite requested a review from a team as a code owner September 13, 2023 14:29
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/java-spanner API. labels Sep 13, 2023
@olavloite olavloite merged commit 9964bd5 into main Sep 25, 2023
@olavloite olavloite deleted the mock-server-fix-query-and-then branch September 25, 2023 08:43
surbhigarg92 pushed a commit to surbhigarg92/java-spanner that referenced this pull request Oct 5, 2023
…#2623)

The mock server that is used for testing contained a queryAndThen(..)
method that did not do anything with the 'and then' part. This PR fixes
that, and adds an additional test using that method. That test shows
what happens with a bit-reversed sequence when a transaction is aborted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants