-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: revert "Feat: Record serialization/deserialization" #1833
Conversation
This reverts commit f5613b4.
When merging this pull request ensure you have "fix:" in the prefix in the commit message. This will ensure the fix will appear in the release note. |
The feature is supposed to be released in this cycle. can we remove it completely from release note, instead of having 2 note: added this feature, fix it by removing it? |
I can manually update release notes to remove this |
Yes, that works. |
clirr check failed https://github.com/googleapis/java-firestore/actions/runs/10927804193/job/30335326929?pr=1833
I marked the check as non-required temporarily. |
This PR is resulting to java cloud bom failure. Reverting the change back till we fixed the java version conflict.
BEGIN_COMMIT_OVERRIDE
fix: revert "Feat: Record serialization/deserialization"
END_COMMIT_OVERRIDE