Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: javadoc on JDK 17 #1812

Closed
wants to merge 3 commits into from
Closed

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Jun 27, 2023

Javadoc is not tested on JDK 17 and it caused a problem.

[INFO] <<< maven-javadoc-plugin:3.5.0:javadoc (default-cli) < generate-sources @ google-cloud-bigtable-stats <<<
[INFO] 
[INFO] 
[INFO] --- maven-javadoc-plugin:3.5.0:javadoc (default-cli) @ google-cloud-bigtable-stats ---
[INFO] No previous run data found, generating javadoc.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Google Cloud Bigtable Parent 2.24.0 ................ SUCCESS [  2.393 s]
[INFO] google-cloud-bigtable-stats 2.24.0 ................. FAILURE [  2.912 s]
[INFO] proto-google-cloud-bigtable-v2 2.24.0 .............. SKIPPED
[INFO] grpc-google-cloud-bigtable-v2 2.24.0 ............... SKIPPED
[INFO] proto-google-cloud-bigtable-admin-v2 2.24.0 ........ SKIPPED
[INFO] grpc-google-cloud-bigtable-admin-v2 2.24.0 ......... SKIPPED
[INFO] google-cloud-bigtable-emulator-core 0.161.0 ........ SKIPPED
[INFO] Google Cloud Java - Bigtable Emulator 0.161.0 ...... SKIPPED
[INFO] Google Cloud Bigtable 2.24.0 ....................... SKIPPED
[INFO] Google Cloud Bigtable BOM 2.24.0 ................... SKIPPED
[INFO] google-cloud-bigtable-deps-bom 2.24.0 .............. SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  7.245 s
[INFO] Finished at: 2023-06-27T18:22:24Z
[INFO] ------------------------------------------------------------------------
Error:  Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:3.5.0:javadoc (default-cli) on project google-cloud-bigtable-stats: An error has occurred in Javadoc report generation: 
Error:  Exit code: 1
Error: [ERROR] error: Malformed URL: [https://googleapis.dev/java/gax/${gax.version}/](https://googleapis.dev/java/gax/$%7Bgax.version%7D/) (java.net.URISyntaxException: Illegal character in path at index 33: [https://googleapis.dev/java/gax/${gax.version}/)](https://googleapis.dev/java/gax/$%7Bgax.version%7D/))
Error: [ERROR] error: Malformed URL: [https://googleapis.github.io/api-common-java/${google.api-common.version}/apidocs/](https://googleapis.github.io/api-common-java/$%7Bgoogle.api-common.version%7D/apidocs/) (java.net.URISyntaxException: Illegal character in path at index 46: [https://googleapis.github.io/api-common-java/${google.api-common.version}/apidocs/)](https://googleapis.github.io/api-common-java/$%7Bgoogle.api-common.version%7D/apidocs/))
Error: [ERROR] 2 errors

@suztomo suztomo requested review from a team as code owners June 27, 2023 18:20
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • .github/workflows/ci.yaml

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigtable Issues related to the googleapis/java-bigtable API. labels Jun 27, 2023
@suztomo
Copy link
Member Author

suztomo commented Jun 27, 2023

Removing the links indeed resolved the issue.

Screenshot 2023-06-27 at 2 29 30 PM

Comment on lines 100 to 111
javadoc:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-java@v3
with:
distribution: zulu
java-version: 17
- run: java -version
- run: .kokoro/build.sh
env:
JOB_TYPE: javadoc
Copy link
Member Author

@suztomo suztomo Jun 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will be overwritten by OwlBot postprocessor's template. So I created googleapis/synthtool#1819

@kolea2 kolea2 closed this Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants