Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix BigQuery#listDatasets to include dataset location in the response #3238

Merged
merged 1 commit into from
Apr 20, 2024
Merged

Fix BigQuery#listDatasets to include dataset location in the response #3238

merged 1 commit into from
Apr 20, 2024

Conversation

sumeetgajjar
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #3237 ☕️

@sumeetgajjar sumeetgajjar requested a review from a team as a code owner April 13, 2024 00:29
@sumeetgajjar sumeetgajjar requested a review from mrfaizal April 13, 2024 00:29
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/java-bigquery API. labels Apr 13, 2024
@sumeetgajjar sumeetgajjar force-pushed the fix_list_dataset_api_location branch 2 times, most recently from 9c3e744 to e30e0d9 Compare April 13, 2024 00:32
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels Apr 13, 2024
@sumeetgajjar sumeetgajjar force-pushed the fix_list_dataset_api_location branch from e30e0d9 to 0668756 Compare April 13, 2024 00:37
@sumeetgajjar
Copy link
Contributor Author

Hi @mrfaizal @PhongChuong - can you please review this PR and trigger cloud CI if the change looks satisfactory?

Thanks in advance.

@sumeetgajjar
Copy link
Contributor Author

Hi @shollyman @PhongChuong @mrfaizal - A gentle ping to review this PR.
Thanks in advance.

@PhongChuong PhongChuong self-requested a review April 20, 2024 13:46
PhongChuong
PhongChuong reviewed Apr 20, 2024
View reviewed changes
Copy link
Contributor

@PhongChuong PhongChuong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing.
Just a minor suggestion to the integration test.

google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITBigQueryTest.java Outdated Show resolved Hide resolved
@sumeetgajjar sumeetgajjar force-pushed the fix_list_dataset_api_location branch from 0668756 to 97f48ff Compare April 20, 2024 14:52
@PhongChuong PhongChuong added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 20, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 20, 2024
@PhongChuong PhongChuong added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Apr 20, 2024
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 20, 2024
@PhongChuong
Copy link
Contributor

Approved. Thanks for contributing.
Sorry for the delay.
Running the integration test now and it should be good to go.

@PhongChuong PhongChuong merged commit c50c17b into googleapis:main Apr 20, 2024
17 of 18 checks passed
@release-please release-please bot mentioned this pull request Apr 19, 2024
Merged
This was referenced Apr 30, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhongChuong PhongChuong PhongChuong approved these changes

@mrfaizal mrfaizal Awaiting requested review from mrfaizal mrfaizal is a code owner automatically assigned from googleapis/api-bigquery

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BigQuery::listDatasets API response does not populate Dataset::location field
3 participants
@sumeetgajjar @PhongChuong @yoshi-kokoro