Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UrlEncodedContent class should use URI path encoding #1098

Closed
guillaumeblaquiere opened this issue Aug 28, 2020 · 0 comments · Fixed by #1100
Closed

UrlEncodedContent class should use URI path encoding #1098

guillaumeblaquiere opened this issue Aug 28, 2020 · 0 comments · Fixed by #1100
Assignees
@yoshi-automation
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@guillaumeblaquiere
Copy link
Contributor

UrlEncodedContent class use a deprecated URL encoder function. For another feature request in Google-auth-library-java (I will paste the link when the issue will be created), I need to use URI path encoding (especially for not encoding the + when I define a list of scopes in the auth library).
This was referenced Aug 28, 2020
Closed
Merged
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Aug 29, 2020
@chingor13 chingor13 added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Sep 2, 2020
@yoshi-automation yoshi-automation removed triage me I really want to be triaged. 🚨 This issue needs some love. labels Sep 2, 2020
@elharo elharo changed the title Improve UrlEncodedContent class to support URI path encoding UrlEncodedContent class should support URI path encoding Oct 7, 2020
@elharo elharo changed the title UrlEncodedContent class should support URI path encoding UrlEncodedContent class should use URI path encoding Oct 7, 2020
gcf-merge-on-green bot pushed a commit that referenced this issue Oct 13, 2020
@guillaumeblaquiere
feat: add flag to allow UrlEncodedContent to use UriPath escaping (#1100
9ab7016 
)

Fixes #1098 
The legacy behavior is kept. Test has been updated
gcf-merge-on-green bot pushed a commit that referenced this issue Oct 13, 2020
@release-please
chore: release 1.37.0 (#1141)
0c1d58b 
🤖 I have created a release \*beep\* \*boop\* 
---
## [1.37.0](https://github.com/googleapis/google-http-java-client/compare/v1.36.0...v1.37.0) (2020-10-13)


### Features

* add flag to allow UrlEncodedContent to use UriPath escaping ([#1100](https://github.com/googleapis/google-http-java-client/issues/1100)) ([9ab7016](https://github.com/googleapis/google-http-java-client/commit/9ab7016032327f6fb0f91970dfbd511b029dd949)), closes [#1098](https://github.com/googleapis/google-http-java-client/issues/1098)


### Bug Fixes

* make google-http-client.properties file shading friendly ([#1046](https://github.com/googleapis/google-http-java-client/issues/1046)) ([860bb05](https://github.com/googleapis/google-http-java-client/commit/860bb0541bcd7fc516cad14dd0d52481c7c7b414))


### Dependencies

* update protobuf-java to 3.13.0 ([#1093](https://github.com/googleapis/google-http-java-client/issues/1093)) ([b7e9663](https://github.com/googleapis/google-http-java-client/commit/b7e96632234e944e0e476dedfc822333716756bb))


### Documentation

* libraries-bom 12.0.0 ([#1136](https://github.com/googleapis/google-http-java-client/issues/1136)) ([450fcb2](https://github.com/googleapis/google-http-java-client/commit/450fcb2293cf3fa7c788cf0cc8ae48e865ae8de8))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yoshi-automation yoshi-automation

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
3 participants
@chingor13 @guillaumeblaquiere @yoshi-automation