-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cloudbuild): generate v1 #9510
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only other library (containeranalysis
) which uses google/cloud/devtools
doesn't declare it as a namespace package, which means that installing it won't be compatible with this one if we continue to ship the library this PR generates.
cloudbuild/google/cloud/devtools/cloudbuild_v1/cloudbuild.proto
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think google/cloud/
is the only namespace package for both?
google/cloud/__init__.py
(namespace package):
google/cloud/devtools/__init__.py
(regular package):
@busunkim96 Try installing |
@tseaver Ah I see. So my options are:
I'll probably do 1, and note in the README that you need google-cloud-containeranalysis>=x.x.x to be able to install side by side with |
I named the directorycloudbuild
rather thanbuild
.The generator names the package
google-cloud-cloudbuild
, but I'd be open to naming itgoogle-cloud-build
. Thoughts?Product team said they preferred
google-cloud-build
, so I've added a synth replace.TODO: