BigQuery Storage: Add more in-depth system tests #8992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
plamut
commented
Aug 9, 2019
| # Compare datetime separately, AVRO and PYARROW return different object types, | ||
| # although they should both represent the same value. | ||
| expected_pattern = re.compile(r"2005-10-26( |T)19:49:41") | ||
| assert expected_pattern.match(str(rows[0]["datetime_field"])) |
There was a problem hiding this comment.
Sanity check - is this expected, or should both AVRO and PYARROW return the exact same type?
Right now one returns a plain ISO datetime string, while the other returns a Timestamp object..
There was a problem hiding this comment.
Answer:
"Expected" is a datetime.datetime object with no timezone. Actual is a string. That's an open issue.
|
FWIW, a system test failure with STRUCT records will be fixed in #9001. |
plamut
force-pushed
the
iss-8983
branch
2 times, most recently
from
e7b1ed2 to
c5f5867
Compare
|
@plamut System tests are failing in setup with the error, |
tswast
reviewed
Aug 14, 2019
plamut
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
A similar method is planned to be added to the library itself, and when done, the _add_rows() will not be needed anymore.
Creating a client once per system tests session avoids the overhead of authenticating before each test case.
Creating a client just once avoids the auth overhead on every system test case.
tswast
approved these changes
Aug 20, 2019
|
I've filed https://github.com/googleapis/google-cloud-python/issues/9066 for the Avro DATETIME issue. |
HemangChothani
pushed a commit
to HemangChothani/google-cloud-python
that referenced
this pull request
Aug 29, 2019
* Add additional BQ storage system test fixtures * Add reader column selection system test * Add basic reader system test * Add reader with row filter system test * Add reading data with snapshot system test * Add reading column partitioned table system test * Add system test for column types data conversions * Add ingestion time partitioned table system test * Add system test for resuming a read at an offset * Remove unnecessary protobuf install in noxfile * Add TODO comment to replace a test helper method A similar method is planned to be added to the library itself, and when done, the _add_rows() will not be needed anymore. * Extract BQ client to session fixture in tests Creating a client once per system tests session avoids the overhead of authenticating before each test case. * Only create BQ storage client once per test run Creating a client just once avoids the auth overhead on every system test case. * Add common credentials fixture for system tests
emar-kar
pushed a commit
to MaxxleLLC/google-cloud-python
that referenced
this pull request
Sep 18, 2019
* Add additional BQ storage system test fixtures * Add reader column selection system test * Add basic reader system test * Add reader with row filter system test * Add reading data with snapshot system test * Add reading column partitioned table system test * Add system test for column types data conversions * Add ingestion time partitioned table system test * Add system test for resuming a read at an offset * Remove unnecessary protobuf install in noxfile * Add TODO comment to replace a test helper method A similar method is planned to be added to the library itself, and when done, the _add_rows() will not be needed anymore. * Extract BQ client to session fixture in tests Creating a client once per system tests session avoids the overhead of authenticating before each test case. * Only create BQ storage client once per test run Creating a client just once avoids the auth overhead on every system test case. * Add common credentials fixture for system tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8983.
This PR adds additional system tests for BigQuery Storage. It does not include the last item from the issue description, i.e. the long-running test, at least not until decided otherwise.
Things to mind
(see the comment below) There is currently an inconsistent type returned for datetime columns (string instead of adatetimeinstance), affecting the same test.Created #9066 for that.