Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firestore: Allow snapshot cursors from other collections for collection group queries. #8882

Merged
merged 1 commit into from
Aug 1, 2019
Merged

Firestore: Allow snapshot cursors from other collections for collection group queries. #8882

merged 1 commit into from
Aug 1, 2019

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Aug 1, 2019

Closes #8633.
Supersedes #8810.

@tseaver tseaver added the api: firestore Issues related to the Firestore API. label Aug 1, 2019
@tseaver tseaver requested a review from crwilcox August 1, 2019 16:57
@tseaver tseaver requested a review from frankyn as a code owner August 1, 2019 16:57
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 1, 2019
@tseaver tseaver mentioned this pull request Aug 1, 2019
Closed
@tseaver tseaver changed the title Allow snapshot cursors from other collections for collection group queries. Firestore: Allow snapshot cursors from other collections for collection group queries. Aug 1, 2019
@tseaver
Copy link
Contributor Author

tseaver commented Aug 1, 2019

Datastore, Phishing Protection, and Translation jobs fail due to Kokoro-internal glitch: "Cannot check out non-mergeable pull request as if merged."

@tseaver tseaver requested a review from BenWhitehead August 1, 2019 17:53
@BenWhitehead BenWhitehead added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 1, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 1, 2019
BenWhitehead
BenWhitehead approved these changes Aug 1, 2019
View reviewed changes
Copy link
Contributor

@BenWhitehead BenWhitehead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IlyaFaer
Copy link

IlyaFaer commented Aug 1, 2019

@tseaver, what does it mean, supersedes? Second time you're taking my PR, rewriting something a little, and pushing your own. How should I understand that?

@tseaver tseaver merged commit a964956 into googleapis:master Aug 1, 2019
gopherbot pushed a commit to googleapis/google-cloud-go that referenced this pull request Dec 4, 2019
@tritone
firestore: fix incorrect validation on CollectionGroup queries
bb047ca 
CollectionGroup queries should be able to use snapshot cursors from
other collections. This is allowed by the API but is prevented by
the client library currently. See similar fix in the python client
here: googleapis/google-cloud-python#8882

Fixes #1659

Change-Id: I71882e5981b97484a8222b47225a75d6da72fc6d
Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/49150
Reviewed-by: kokoro <[email protected]>
Reviewed-by: BenWhitehead <[email protected]>
Reviewed-by: Jean de Klerk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenWhitehead BenWhitehead BenWhitehead approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

@frankyn frankyn Awaiting requested review from frankyn

Assignees
No one assigned
Labels
api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Firestore: collection_group query with start_after passing a snapshot
5 participants
@tseaver @IlyaFaer @BenWhitehead @googlebot @yoshi-kokoro