Firestore: Expand dotted keys in mappings used as cursors. #8568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchauhan-qlogic
requested review from
crwilcox,
frankyn and
tseaver
as code owners
googlebot
added
the
cla: yes
AVaksman
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
tseaver
suggested changes
Aug 1, 2019
There was a problem hiding this comment.
The actual fix looks OK here (assuming that @BenWhitehead connfirms that we are supposed to handle this case). Please update the systest to exercise the "dotted-key-in-cursor" behavior, as per my gist.
tseaver
changed the title
tseaver
changed the title
pchauhan-qlogic
force-pushed
the
firestore_pagination_with_map_field_errors_4587
branch
from
4b5cda4 to
386f330
Compare
|
@pchauhan-qlogic This PR still needs conflicts resolved: please |
pchauhan-qlogic
force-pushed
the
firestore_pagination_with_map_field_errors_4587
branch
from
386f330 to
6bb0ab7
Compare
tseaver
reviewed
Aug 6, 2019
tseaver
approved these changes
Aug 7, 2019
tseaver
suggested changes
Aug 7, 2019
There was a problem hiding this comment.
Lint fails on CI. Please run nox -r blacken and then nox -r lint to check that it passes before committing.
tseaver
approved these changes
Aug 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7756