Firestore: Add gRPC keepalive to Client Init. #8264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tseaver
suggested changes
Jun 8, 2019
tseaver
changed the title
crwilcox
force-pushed
the
keepalive-grpc-listen
branch
from
3d6809f to
2f0d4d5
Compare
crwilcox
force-pushed
the
keepalive-grpc-listen
branch
from
2f0d4d5 to
614639d
Compare
crwilcox
force-pushed
the
keepalive-grpc-listen
branch
from
c2306e4 to
f148b6d
Compare
crwilcox
force-pushed
the
keepalive-grpc-listen
branch
from
73a172d to
bfb402a
Compare
tseaver
reviewed
Jul 1, 2019
| Returns: | ||
| str: The location of the API. | ||
| """ | ||
| return firestore_client.FirestoreClient.SERVICE_ADDRESS |
There was a problem hiding this comment.
This is going to clash with @busunkim96's client_info work.
tseaver
approved these changes
Jul 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to run a listen for longer than one our, gRPC needs to be configured to keep the connection alive. These changes are in generated code here though and shouldn't be merged.
b/130522486