Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Video Intelligence: Add empty lines (via synth). #8077

Closed
wants to merge 1 commit into from
Closed

Video Intelligence: Add empty lines (via synth). #8077

wants to merge 1 commit into from

Conversation

yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Executing /tmpfs/src/git/autosynth/working_repo/videointelligence/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:3246adac900f4bdbd62920e80de2e5877380e44036b3feae13667ec255ebf5ec
Status: Image is up to date for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/cloud/videointelligence/artman_videointelligence_v1beta1.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/video-intelligence-v1beta1.
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/videointelligence/v1beta1/video_intelligence.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/video-intelligence-v1beta1/google/cloud/videointelligence_v1beta1/proto/video_intelligence.proto
synthtool > Placed proto files into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/video-intelligence-v1beta1/google/cloud/videointelligence_v1beta1/proto.
synthtool > Running generator for google/cloud/videointelligence/artman_videointelligence_v1beta2.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/video-intelligence-v1beta2.
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/videointelligence/v1beta2/video_intelligence.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/video-intelligence-v1beta2/google/cloud/videointelligence_v1beta2/proto/video_intelligence.proto
synthtool > Placed proto files into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/video-intelligence-v1beta2/google/cloud/videointelligence_v1beta2/proto.
synthtool > Running generator for google/cloud/videointelligence/artman_videointelligence_v1p1beta1.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/video-intelligence-v1p1beta1.
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/videointelligence/v1p1beta1/video_intelligence.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/video-intelligence-v1p1beta1/google/cloud/videointelligence_v1p1beta1/proto/video_intelligence.proto
synthtool > Placed proto files into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/video-intelligence-v1p1beta1/google/cloud/videointelligence_v1p1beta1/proto.
synthtool > Running generator for google/cloud/videointelligence/artman_videointelligence_v1p2beta1.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/video-intelligence-v1p2beta1.
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/videointelligence/v1p2beta1/video_intelligence.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/video-intelligence-v1p2beta1/google/cloud/videointelligence_v1p2beta1/proto/video_intelligence.proto
synthtool > Placed proto files into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/video-intelligence-v1p2beta1/google/cloud/videointelligence_v1p2beta1/proto.
synthtool > Running generator for google/cloud/videointelligence/artman_videointelligence_v1p3beta1.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/video-intelligence-v1p3beta1.
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/videointelligence/v1p3beta1/video_intelligence.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/video-intelligence-v1p3beta1/google/cloud/videointelligence_v1p3beta1/proto/video_intelligence.proto
synthtool > Placed proto files into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/video-intelligence-v1p3beta1/google/cloud/videointelligence_v1p3beta1/proto.
synthtool > Running generator for google/cloud/videointelligence/artman_videointelligence_v1.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/video-intelligence-v1.
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/videointelligence/v1/video_intelligence.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/video-intelligence-v1/google/cloud/videointelligence_v1/proto/video_intelligence.proto
synthtool > Placed proto files into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/video-intelligence-v1/google/cloud/videointelligence_v1/proto.
synthtool > No replacements made in **/*/*video_intelligence_service_client.py for pattern 'google-cloud-video-intelligence', \).version, maybe replacement is not longer needed?
synthtool > Replaced '^(\\s+)expected_request = video_intelligence_pb2.AnnotateVideoRequest\\(\\)' in tests/unit/gapic/v1p1beta1/test_video_intelligence_service_client_v1p1beta1.py.
synthtool > Replaced '^(\\s+)expected_request = video_intelligence_pb2.AnnotateVideoRequest\\(\\)' in tests/unit/gapic/v1p3beta1/test_video_intelligence_service_client_v1p3beta1.py.
synthtool > Replaced '^(\\s+)expected_request = video_intelligence_pb2.AnnotateVideoRequest\\(\\)' in tests/unit/gapic/v1beta2/test_video_intelligence_service_client_v1beta2.py.
synthtool > Replaced '^(\\s+)expected_request = video_intelligence_pb2.AnnotateVideoRequest\\(\\)' in tests/unit/gapic/v1/test_video_intelligence_service_client_v1.py.
synthtool > Replaced '^(\\s+)expected_request = video_intelligence_pb2.AnnotateVideoRequest\\(\\)' in tests/unit/gapic/v1p2beta1/test_video_intelligence_service_client_v1p2beta1.py.
.coveragerc
.flake8
MANIFEST.in
noxfile.py.j2
setup.cfg
Running session blacken
Creating virtualenv using python3.6 in /tmpfs/src/git/autosynth/working_repo/videointelligence/.nox/blacken
pip install black
black google tests docs
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/__init__.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/__init__.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1/__init__.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1/gapic/enums.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1/gapic/transports/video_intelligence_service_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1/gapic/video_intelligence_service_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1/proto/video_intelligence_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/docs/conf.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1beta1/__init__.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1/types.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1beta1/gapic/enums.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1/gapic/video_intelligence_service_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1beta1/gapic/transports/video_intelligence_service_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1beta1/gapic/video_intelligence_service_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1beta1/proto/video_intelligence_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1beta1/types.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1beta2/__init__.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1beta1/gapic/video_intelligence_service_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1beta2/gapic/enums.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1beta2/gapic/transports/video_intelligence_service_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1beta2/gapic/video_intelligence_service_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1beta2/gapic/video_intelligence_service_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1beta2/proto/video_intelligence_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1beta2/types.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p1beta1/__init__.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p1beta1/gapic/enums.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p1beta1/gapic/transports/video_intelligence_service_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p1beta1/gapic/video_intelligence_service_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p1beta1/gapic/video_intelligence_service_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1beta1/proto/video_intelligence_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p1beta1/proto/video_intelligence_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p1beta1/types.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p2beta1/__init__.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p2beta1/gapic/enums.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p2beta1/gapic/transports/video_intelligence_service_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1beta2/proto/video_intelligence_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p2beta1/gapic/video_intelligence_service_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p2beta1/gapic/video_intelligence_service_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p2beta1/proto/video_intelligence_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p2beta1/types.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p3beta1/__init__.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p3beta1/gapic/enums.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p3beta1/gapic/streaming_video_intelligence_service_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p3beta1/gapic/streaming_video_intelligence_service_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p3beta1/gapic/transports/streaming_video_intelligence_service_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p3beta1/gapic/transports/video_intelligence_service_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p3beta1/gapic/video_intelligence_service_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p3beta1/gapic/video_intelligence_service_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p1beta1/proto/video_intelligence_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p3beta1/proto/video_intelligence_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p3beta1/types.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/tests/unit/gapic/v1/test_video_intelligence_service_client_v1.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1/proto/video_intelligence_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/tests/unit/gapic/v1beta1/test_video_intelligence_service_client_v1beta1.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/tests/unit/gapic/v1beta2/test_video_intelligence_service_client_v1beta2.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/tests/unit/gapic/v1p1beta1/test_video_intelligence_service_client_v1p1beta1.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/tests/unit/gapic/v1p2beta1/test_video_intelligence_service_client_v1p2beta1.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/tests/unit/gapic/v1p3beta1/test_streaming_video_intelligence_service_client_v1p3beta1.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/tests/unit/gapic/v1p3beta1/test_video_intelligence_service_client_v1p3beta1.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p2beta1/proto/video_intelligence_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p3beta1/proto/video_intelligence_pb2.py
All done! ✨ 🍰 ✨
62 files reformatted, 18 files left unchanged.
Session blacken was successful.
synthtool > Cleaned up 2 temporary directories.
synthtool > Wrote metadata to synth.metadata.

@yoshi-automation yoshi-automation added the api: videointelligence Issues related to the Video Intelligence API API. label May 21, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 21, 2019
busunkim96
busunkim96 reviewed May 21, 2019
View reviewed changes
...lligence/google/cloud/videointelligence_v1p2beta1/gapic/video_intelligence_service_client.py
_GAPIC_LIBRARY_VERSION = pkg_resources.get_distribution(
"google-cloud-videointelligence"
"google-cloud-video-intelligence"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what generator change is making this happen. 😕

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we need to extend this synth replacement to cover the spread out version:

google-cloud-python/videointelligence/synth.py

Lines 52 to 56 in ba1ddc2

s.replace(
"**/*/*video_intelligence_service_client.py",
"'google-cloud-video-intelligence', \).version",
"'google-cloud-videointelligence', ).version",
)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@busunkim96 I have a manual synth PR coming which fixes the replacement.

@busunkim96 busunkim96 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 21, 2019
@busunkim96 busunkim96 changed the title [CHANGE ME] Re-generated videointelligence to pick up changes in the API or client library generator. Video Intelligence: Add empty lines (via synth). May 21, 2019
@tseaver tseaver mentioned this pull request May 22, 2019
Merged
@tseaver
Copy link
Contributor

tseaver commented May 22, 2019

Superseded by #8104.

@tseaver tseaver closed this May 22, 2019
@tseaver tseaver deleted the autosynth-videointelligence branch May 22, 2019 21:05
tseaver added a commit that referenced this pull request May 22, 2019
@tseaver
Harden synth replacement against template changes. (#8104)
67d8504 
Supersedes #8077.
parthea pushed a commit that referenced this pull request Sep 22, 2023
@tseaver
Harden synth replacement against template changes. (#8104)
0b41db0 
Supersedes #8077.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver left review comments

@busunkim96 busunkim96 busunkim96 left review comments

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: videointelligence Issues related to the Video Intelligence API API. cla: yes This human has signed the Contributor License Agreement. codegen do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yoshi-automation @tseaver @busunkim96 @googlebot