PubSub: Propagate subscribe callback errors to main thread #7954
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7917.
This PR implements a user request to propagate exceptions from streaming pull callbacks to the main thread awaiting the result of the future returned by the
subscriber.subscribe()
call.How to test
Steps to reproduce:
Actual result (before the fix):
fut.result()
.Expected result (after the fix):
fut.result()
, and the main thread exists almost immediately after the callback is invoked.