Pub/Sub ThreadScheduler should inherit from the base Scheduler ABC #7690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tseaver
approved these changes
Apr 16, 2019
plamut
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
plamut
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
plamut
force-pushed
the
scheduler-subclass
branch
from
754124f to
be9b6a3
Compare
|
@tseaver What does the rotating light label warn about? Is this PR safe to merge? |
|
@plamut, the rotating light indicates that this PR is old and should get additional attention from reviewers. Please feel free to merge. |
|
@sduskis Thank you, will happily do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the
ThreadSchedulerto subclass the baseScheduler(and notobject).How to test
Carefully gaze at the
scheduler.ThreadSchedulerclass definition for about 3.14 seconds and await the Enlightenment. 😉I see no apparent reason, why
ThreadSchedulersubclassesobjectdirectly, instead of the ABC defined in the very same file, as the interfaces of these two classes match.