-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing projection=full from Blob/Bucket PATCH requests. #758
Conversation
I'm not aware of any issues, but is there a reason to specify noAcl? What if you're patching the ACL, don't you want to see the new one? Projection=full won't return the acl to you unless you have OWNER permission on the bucket/object anyway. |
RE: "is there a reason to specify noAcl" That is a discussion in flux. Currently ACL behavior is managed via dedicated objects instead of directly with the RE: "won't return the acl to you unless you have OWNER permission" I would wager that was the original author's concern. Thanks! |
The API docs say:
|
@dhermes It has to do with the way that patch currently is implemented. I suspect that if you had custom ACLs on your bucket that if you patch with no_acl, you inadvertently reset your bucket ACL to project-private. |
I see.
|
Closing, based on "we do not need this" and also there is no possible way we would successfully wrangle a PR this old in even if we did. |
There was a previous comment
I tested a little with this and it doesn't seem to be an issue.
@thobrla Can you confirm or deny any issues with
projection=full
?