-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BigQuery: Add tqdm progress bar for downloads #7552
Merged
+219
−20
Merged
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
d309212
Add tqdm progressbar for bigquery downloads
JohnPaton c6efe1b
Catch any tqdm errors during progress bar construction
JohnPaton b23d581
Update total rows in progress bar during download
JohnPaton 3c1f008
tqdm import to pandas pattern
JohnPaton c0e3a39
unit tests for download progress bar
JohnPaton 0693789
Add tqdm to setup.py extras
JohnPaton 9506caa
Merge branch 'master' into progressbar-download
JohnPaton a7d9d59
Make progress bar tests more specific
JohnPaton 25f4e13
Style adjustments to improve clarity
JohnPaton 4aafefe
Add progress_bar_type argument to to_dataframe
tswast 62e3d58
Fix lint, coverage, and docs errors.
tswast bed0694
Add shared variable for common tqdm description.
tswast File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a
progress_bar_type
(string) parameter toto_dataframe
and check that it also is not None.It should default to
None
for now, until we update the magics module to support turning it off in theContext
and also update the magics to use thetqdm_notebook
option instead.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I think defaulting to
'tqdm'
is fine. When @alixhami tests notebooks, he can setgoogle.cloud.bigquery.table.tqdm = None
like you do in your tests.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should default to
None
because otherwise it will throw errors for users who don't havetqdm
installed who aren't using the parameter.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in the latest commits.