Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BigQuery Storage API client (currently alpha) #6696

Merged
merged 6 commits into from
Nov 29, 2018

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Nov 29, 2018

This PR adds the BigQuery Storage API client (currently an alpha API).

Note that these changes have already been reviewed in the private repo.

* Add simple system test for BigQuery Storage API

For the system tests to run correctly, an unreleased version of api_core
is required. Updates the setup.py file to indicate the minimum version.

* Remove mock dependency and unnecessary imports.

* Use -e for local deps.
* Add manual client for BigQuery Storage.

The manual client adds a default project, which is used by the wrapped
create_read_session to make the project parameter optional.

A future purpose of the manual client is to override the read_rows
method to return an iterator that can reconnect with the correct offset,
much like Spanner's StreamedResultSet class. This work is not yet
complete.  I'd like feedback on the approach for the manual client
first.

* Use same client name as wrapped gapic class.

* Use subclass for BigQueryStorageClient

Also, change create_read_session project argument back to 'parent' to
better match the super class.

* Add unit tests.

* Remove default project from manual client.
* Regenerate google-cloud-bigquery-storage

* Re-synthed
* WIP: reader to reconnect on ReadRows streams

* Add method to copy a StreamPosition.

* Add unit tests for hand-written reader module.

* Add docs for new hand-written module.

* Add fastavro to root intersphinx

* Add ServiceUnavailable to list of resumable exceptions.

Pull in .coveragerc file from upstream google-cloud-python.
@tswast tswast requested a review from crwilcox as a code owner November 29, 2018 20:10
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 29, 2018
@tswast tswast requested review from shollyman and alixhami November 29, 2018 20:11
@tswast tswast added the api: bigquery Issues related to the BigQuery API. label Nov 29, 2018
@@ -0,0 +1,75 @@
Python Client for BigQuery Storage API (`Alpha`_)

This comment was marked as spam.

This comment was marked as spam.

@tswast tswast merged commit b56a534 into googleapis:master Nov 29, 2018
@tswast tswast deleted the bigquery-storage branch November 29, 2018 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants