Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raising exception when dataset ID can't be implied in set_default... #610

Merged
merged 1 commit into from
Feb 12, 2015
Merged

Raising exception when dataset ID can't be implied in set_default... #610

merged 1 commit into from
Feb 12, 2015

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Feb 10, 2015

Fixes #475.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 10, 2015
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 06bc62f on dhermes:raise-if-no-default-dataset into b395360 on GoogleCloudPlatform:master.

tseaver
tseaver reviewed Feb 10, 2015
View reviewed changes
gcloud/datastore/__init__.py
@@ -92,6 +94,8 @@ def set_default_dataset_id(dataset_id=None):

if dataset_id is not None:
_implicit_environ.DATASET_ID = dataset_id
else:
raise EnvironmentError('No dataset ID could be implied.')

This comment was marked as spam.

Sign in to view

@tseaver
Copy link
Contributor

tseaver commented Feb 10, 2015

Except for the "implied" vs. "inferred" bit, LGTM

@dhermes dhermes force-pushed the raise-if-no-default-dataset branch from 06bc62f to 01f89a8 Compare February 12, 2015 07:12
@dhermes
Copy link
Contributor Author

dhermes commented Feb 12, 2015

Folding into original commit. I apparently can't keep these two straight :)

@dhermes
Copy link
Contributor Author

dhermes commented Feb 12, 2015

@tseaver It seems we are experiencing a coveralls outage. I'm going to merge, cover passing locally.

Any ideas?

dhermes added a commit that referenced this pull request Feb 12, 2015
@dhermes
Merge pull request #610 from dhermes/raise-if-no-default-dataset
b84fe13 
Raising exception when dataset ID can't be implied in set_default...
@dhermes dhermes merged commit b84fe13 into googleapis:master Feb 12, 2015
@dhermes dhermes deleted the raise-if-no-default-dataset branch February 12, 2015 07:35
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 01f89a8 on dhermes:raise-if-no-default-dataset into b395360 on GoogleCloudPlatform:master.

This was referenced Feb 12, 2015
Closed
Merged
vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
@renovate-bot
chore(deps): update dependency google-cloud-dialogflow to v2.19.0 (#610)
c6f79cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add GAE/GCE support for datastore.set_default_dataset and add exception on failure
4 participants
@dhermes @coveralls @tseaver @googlebot