BigQuery: add from_string factory methods to Dataset and Table #5255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make it easier to construct Datasets and Tables when the
full-qualified ID is known ahead of time, this PR adds helper methods
called `from_string` to Dataset, DatasetReference, Table, and
TableReference. In each case, the expected format is a fully-qualified
ID (including the project ID) in standard SQL format.
```
dataset = client.create_dataset(
bigquery.Dataset(
client.dataset('mydataset', project='other-project')
)
)
```
becomes
```
dataset = client.create_dataset(
bigquery.Dataset.from_string('other-project.mydataset')
)
```
Also, while writing doctests/examples, I noticed `__repr__` was
inconsistent with the actual constructor on some of these classes, so I
fixed that while I was here so those string representations don't cause
confusion.
googlebot
added
the
cla: yes
|
Thanks a lot! |
max-sixty
reviewed
Apr 27, 2018
| 'standard SQL format. e.g. "project.dataset.table", got ' | ||
| '{}'.format(full_table_id)) | ||
|
|
||
| return cls(DatasetReference(parts[0], parts[1]), parts[2]) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
alixhami
approved these changes
Apr 27, 2018
| standard SQL format. | ||
| """ | ||
| dataset_ref = DatasetReference.from_string(full_dataset_id) | ||
| return cls(dataset_ref) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| standard SQL format. | ||
| """ | ||
| table_ref = TableReference.from_string(full_table_id) | ||
| return cls(table_ref) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make it easier to construct Datasets and Tables when the
full-qualified ID is known ahead of time, this PR adds helper methods
called
from_stringto Dataset, DatasetReference, Table, andTableReference. In each case, the expected format is a fully-qualified
ID (including the project ID) in standard SQL format.
becomes
Also, while writing doctests/examples, I noticed
__repr__wasinconsistent with the actual constructor on some of these classes. I
fixed that while I was here so those string representations don't cause
confusion.
/cc @maxim-lian