Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigQuery: Integration with IPython including cell magic for running queries #4983

Merged
merged 10 commits into from
Mar 12, 2018

Conversation

alixhami
Copy link
Contributor

@alixhami alixhami commented Mar 1, 2018

The intent of this PR is to create an IPython magic that can be used in any IPython notebook (whether hosted or local), and open the potential for future magics and integrations with notebooks.

@alixhami alixhami added the api: bigquery Issues related to the BigQuery API. label Mar 1, 2018
@alixhami alixhami requested review from tswast and theacodes March 1, 2018 18:55
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 1, 2018
@tswast
Copy link
Contributor

tswast commented Mar 1, 2018

/cc @craigcitro

bigquery/google/cloud/bigquery/magics.py Outdated Show resolved Hide resolved
bigquery/google/cloud/bigquery/magics.py Outdated Show resolved Hide resolved
bigquery/google/cloud/bigquery/magics.py Outdated Show resolved Hide resolved
bigquery/google/cloud/bigquery/magics.py Outdated Show resolved Hide resolved
bigquery/tests/system.py Outdated Show resolved Hide resolved
Copy link
Contributor

@craigcitro craigcitro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking nice! I tried it out:
https://colab.research.google.com/drive/1f3ZrIkYfGmdVWnwD08FpnJGubHWrmVlI

One issue (comment below), but looks good at a glance! I'll dig a little more soon (I hope).

bigquery/google/cloud/bigquery/magics.py Outdated Show resolved Hide resolved
bigquery/google/cloud/bigquery/__init__.py Outdated Show resolved Hide resolved
bigquery/google/cloud/bigquery/magics.py Outdated Show resolved Hide resolved
bigquery/google/cloud/bigquery/magics.py Outdated Show resolved Hide resolved
bigquery/google/cloud/bigquery/magics.py Outdated Show resolved Hide resolved
bigquery/google/cloud/bigquery/magics.py Outdated Show resolved Hide resolved
bigquery/tests/system.py Outdated Show resolved Hide resolved
bigquery/tests/unit/test_magics.py Outdated Show resolved Hide resolved
bigquery/tests/unit/test_magics.py Outdated Show resolved Hide resolved
@theacodes theacodes merged commit 48a66b7 into googleapis:master Mar 12, 2018
@alixhami alixhami deleted the bigquery-magics branch March 15, 2018 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants