Distinguish FieldPath classes from field path strings #4466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
chemelnucfin
force-pushed
the
4378-fieldpathclass-part2
branch
from
5daa7e0 to
8e1dd56
Compare
chemelnucfin
added
the
type: feature request
chemelnucfin
changed the title
chemelnucfin
force-pushed
the
4378-fieldpathclass-part2
branch
from
8e1dd56 to
d25c432
Compare
schmidt-sebastian
suggested changes
Mar 16, 2018
| # "Cheat" and use OrderedDict-s so that iteritems() is deterministic. | ||
| field_updates = collections.OrderedDict(( | ||
| ('a.b.c', 10), | ||
| ('d', None), | ||
| ('e.f1', [u'no', b'yes']), | ||
| ('e.f2', 4.5), | ||
| (FieldPath.from_string('e.f3').to_api_repr(), (3, 1)), |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
chemelnucfin
force-pushed
the
4378-fieldpathclass-part2
branch
7 times, most recently
from
2ded7ab to
984eed5
Compare
chemelnucfin
force-pushed
the
4378-fieldpathclass-part2
branch
from
984eed5 to
c5c3487
Compare
|
@schmidt-sebastian I fixed a bug where the regex did not match the entire group, and added some new tests to ensure the behavior, PTAL. Thanks. |
schmidt-sebastian
approved these changes
Mar 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please wait until #4392 and #4464 is merged first.Merged