Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip user_project-based rewrite tests if envvar is not set. #4175

Merged
merged 1 commit into from
Oct 12, 2017
Merged

Skip user_project-based rewrite tests if envvar is not set. #4175

merged 1 commit into from
Oct 12, 2017

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Oct 12, 2017

No description provided.

@tseaver tseaver added api: storage Issues related to the Cloud Storage API. testing labels Oct 12, 2017
@tseaver tseaver requested a review from dhermes October 12, 2017 18:59
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 12, 2017
dhermes
dhermes approved these changes Oct 12, 2017
View reviewed changes
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (very tough to review this!)

@tseaver
Copy link
Contributor Author

tseaver commented Oct 12, 2017

(very tough to review this!)

Neither of those tests is sensible if the environment variable is not set.

@tseaver tseaver merged commit c0bbf6d into googleapis:master Oct 12, 2017
@tseaver tseaver deleted the storage-systest-skip-rewrite-user_project branch October 12, 2017 19:06
@dhermes
Copy link
Contributor

dhermes commented Oct 12, 2017

(sarcasm)

@tseaver
Copy link
Contributor Author

tseaver commented Oct 12, 2017

(tone deaf) :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhermes dhermes dhermes approved these changes

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @dhermes @googlebot