BigQuery: Updates Table constructor to use TableReference as parameter #3997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
alixhami
force-pushed
the
bq-table-constructor
branch
from
f81e021 to
69e7eea
Compare
tswast
reviewed
Sep 18, 2017
| @@ -623,7 +623,8 @@ def table(self, name, schema=()): | |||
| :rtype: :class:`google.cloud.bigquery.table.Table` | |||
| :returns: a new ``Table`` instance | |||
| """ | |||
| return Table(name, dataset=self, schema=schema) | |||
| table_ref = TableReference(self, name) | |||
| return Table(table_ref, schema=schema, client=self._client) | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
tswast
pushed a commit
that referenced
this pull request
Sep 25, 2017
#3997) * wip update Table contructor * BigQuery: Updates Table constructor to use TableReference as parameter * fixes circular import error with Python 2.7
tswast
pushed a commit
that referenced
this pull request
Oct 12, 2017
#3997) * wip update Table contructor * BigQuery: Updates Table constructor to use TableReference as parameter * fixes circular import error with Python 2.7
tswast
pushed a commit
that referenced
this pull request
Oct 16, 2017
#3997) * wip update Table contructor * BigQuery: Updates Table constructor to use TableReference as parameter * fixes circular import error with Python 2.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.