Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo correction. #3910

Merged
merged 2 commits into from
Sep 1, 2017
Merged

Typo correction. #3910

merged 2 commits into from
Sep 1, 2017

Conversation

lukesneeringer
Copy link
Contributor

@lukesneeringer lukesneeringer commented Sep 1, 2017 •
edited
Loading

Fixes #3894. Fixes #3895.

@lukesneeringer lukesneeringer self-assigned this Sep 1, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 1, 2017
tseaver
tseaver reviewed Sep 1, 2017
View reviewed changes
runtimeconfig/google/cloud/runtimeconfig/config.py Outdated
@@ -187,7 +187,7 @@ def get_variable(self, variable_name, client=None):
>>> from google.cloud import runtimeconfig
>>> client = runtimeconfig.Client()
>>> config = client.get_config('my-config')

This comment was marked as spam.

Sign in to view

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Sep 1, 2017
@lukesneeringer
Copy link
Contributor Author

Shaddup @googlebot.

@lukesneeringer lukesneeringer added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 1, 2017
@lukesneeringer lukesneeringer merged commit c294732 into googleapis:master Sep 1, 2017
@lukesneeringer lukesneeringer deleted the issue-3895 branch September 1, 2017 20:23
tswast
tswast reviewed Sep 5, 2017
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast left review comments

@tseaver tseaver tseaver left review comments

Assignees

@lukesneeringer lukesneeringer

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lukesneeringer @googlebot @tseaver @tswast