BigQuery: make get_query_results private. Return rows for QueryJob.result() #3883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sult()
get_query_results is too low level to expose directly to users.
Based on feedback from others in the redesign plan, the result() object
should just return the rows as an iterator. This simplifies the proposed
query interface to:
job = client.query('MY QUERY')
rows = job.result()
No need for separate fetch_data() call after calling result().
googlebot
added
the
cla: yes
dhermes
reviewed
Aug 25, 2017
| @@ -154,7 +154,7 @@ def execute(self, operation, parameters=None, job_id=None): | |||
|
|
|||
| # Wait for the query to finish. | |||
| try: | |||
| query_job = query_job.result() | |||
| query_job.result() | |||
| except google.cloud.exceptions.GoogleCloudError: | |||
| raise exceptions.DatabaseError(query_job.errors) | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on feedback from others in the redesign plan.
The
get_query_results()function is too low level to expose directly to users.The result() object should just return the rows as an iterator. This simplifies the proposed query interface to:
No need for separate fetch_data() call after calling result().