Fix #26: expose bucket iterator w extra params #359

tseaver · 2014-11-08T19:02:15Z

Presumes #358 is landed first.

Exposes additional paramters for narrowing / batching key search.

Fixes #26.

coveralls · 2014-11-08T19:05:10Z

Changes Unknown when pulling 77ccaf1 on tseaver:26-expose_bucket_iterator_w_extra_params into * on GoogleCloudPlatform:master*.

coveralls · 2014-11-10T17:54:33Z

Changes Unknown when pulling 4976986 on tseaver:26-expose_bucket_iterator_w_extra_params into * on GoogleCloudPlatform:master*.

coveralls · 2014-11-10T19:37:43Z

Changes Unknown when pulling 18b954d on tseaver:26-expose_bucket_iterator_w_extra_params into * on GoogleCloudPlatform:master*.

dhermes · 2014-11-10T20:17:03Z

Shouldn't these changes land in #358 first?

tseaver · 2014-11-10T21:50:06Z

@dhermes I will rebase after #368 and #358 land (and remove 'pylintrc_default' changes).

dhermes · 2014-11-11T22:46:01Z

Ping me after rebase?

coveralls · 2014-11-11T23:25:17Z

Changes Unknown when pulling 29511bb on tseaver:26-expose_bucket_iterator_w_extra_params into * on GoogleCloudPlatform:master*.

tseaver · 2014-11-11T23:39:18Z

@dhermes rebased done.

gcloud/storage/bucket.py

+        """
+        extra_params = {}
+
+        if prefix is not None:


dhermes · 2014-11-11T23:53:45Z

LGTM, my question is more a curiosity than anything.

Can you double check the regression test still passes before merging?

Also, do you want to use the Bucket.iterator method to make regression/storage.py better (e.g. https://github.com/GoogleCloudPlatform/gcloud-python/blob/bc8b1c4a27563ad97912456de102d93bb602051e/regression/storage.py#L193)

If not, I can group it in with #336

tseaver · 2014-11-11T23:58:23Z

You are correct that the TestStorageListFiles regression test fails (because _KeyIterator moved).

I will update it to use bucket.iterator.

coveralls · 2014-11-12T00:05:17Z

Changes Unknown when pulling eabbd06 on tseaver:26-expose_bucket_iterator_w_extra_params into * on GoogleCloudPlatform:master*.

Exposes additional paramters for narrowing / batching key search. Fixes #26.

See: #359 (comment)

tseaver · 2014-11-12T00:24:12Z

@dhermes "This time for sure, Rocky!" (rebased to pick up the #364 merge).

coveralls · 2014-11-12T00:26:10Z

Changes Unknown when pulling faf8595 on tseaver:26-expose_bucket_iterator_w_extra_params into * on GoogleCloudPlatform:master*.

…a_params Fix #26: expose bucket iterator w extra params

* chore: Use gapic-generator-python 0.65.0 PiperOrigin-RevId: 440970084 Source-Link: googleapis/googleapis@5e0a3d5 Source-Link: googleapis/googleapis-gen@b0c628a Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjBjNjI4YTNmYWRlNzY4ZjIyNWQ3Njk5Mjc5MWVhMWJhMmE4ODFiZSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…359) Source-Link: googleapis/synthtool@8e55b32 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:c6c965a4bf40c19011b11f87dbc801a66d3a23fbc6704102be064ef31c51f1c3

* chore(deps): update all dependencies * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * revert Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>

Source-Link: googleapis/synthtool@50db768 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e09366bdf0fd9c8976592988390b24d53583dd9f002d476934da43725adbb978 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@69fabae Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:562802bfac02e012a6ac34eda282f81d06e77326b82a32d7bbb1369ff552b387

Co-authored-by: Anthonios Partheniou <[email protected]>

* docs: Fix formatting of request arg in docstring chore: Update gapic-generator-python to v1.9.1 PiperOrigin-RevId: 518604533 Source-Link: googleapis/googleapis@8a085ae Source-Link: googleapis/googleapis-gen@b2ab4b0 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJhYjRiMGEwYWUyOTA3ZTgxMmMyMDkxOThhNzRlMDg5OGFmY2IwNCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>

Source-Link: googleapis/synthtool@6fab84a Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:7cffbc10910c3ab1b852c05114a08d374c195a81cdec1d4a67a1d129331d0bfe

Source-Link: https://github.com/googleapis/synthtool/commit/eaef28efd179e6eeb9f4e9bf697530d074a6f3b9 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f8ca7655fa8a449cadcabcbce4054f593dcbae7aeeab34aa3fcc8b5cf7a93c9e

* chore: Update gapic-generator-python to v1.8.4 PiperOrigin-RevId: 507808936 Source-Link: googleapis/googleapis@64cf849 Source-Link: googleapis/googleapis-gen@53c48ca Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTNjNDhjYWMxNTNkM2IzN2YzZDJjMmRlYzQ4MzBjZmQ5MWVjNDE1MyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@c4dd595 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ce3c1686bc81145c81dd269bd12c4025c6b275b22d14641358827334fddb1d72 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore(python): use cov_level in unittest gh action Source-Link: googleapis/synthtool@e5aaa84 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:d22cd2ddce65fdac6986f115563faf2fc81482b09dfbea83ac2808c92ecfdff0 * set coverage to 100% Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>

…pprove] (#359) Source-Link: https://github.com/googleapis/synthtool/commit/e3a1277ac35fc88c09db1930533e24292b132ced Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:452901c74a22f9b9a3bd02bce780b8e8805c97270d424684bff809ce5be8c2a2

Source-Link: https://github.com/googleapis/synthtool/commit/26c7505b2f76981ec1707b851e1595c8c06e90fc Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f946c75373c2b0040e8e318c5e85d0cf46bc6e61d0a01f3ef94d8de974ac6790

Source-Link: https://github.com/googleapis/synthtool/commit/25083af347468dd5f90f69627420f7d452b6c50e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e6cbd61f1838d9ff6a31436dfc13717f372a7482a82fc1863ca954ec47bff8c8

* chore: Update gapic-generator-python to v1.11.3 PiperOrigin-RevId: 546899192 Source-Link: googleapis/googleapis@e6b1691 Source-Link: googleapis/googleapis-gen@0b3917c Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGIzOTE3YzQyMWNiZGE3ZmNiNjcwOTJlMTZjMzNmM2VhNDZmNGJjNyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: Update gapic-generator-python to v1.11.4 PiperOrigin-RevId: 547897126 Source-Link: googleapis/googleapis@c09c75e Source-Link: googleapis/googleapis-gen@45e0ec4 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDVlMGVjNDM0MzUxN2NkMGFhNjZiNWNhNjQyMzJhMTgwMmMyZjk0NSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: https://github.com/googleapis/synthtool/commit/909573ce9da2819eeb835909c795d29aea5c724e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ddf4551385d566771dc713090feb7b4c1164fb8a698fe52bbe7670b24236565b

* chore: remove obsolete proto folder * Update UPGRADING.md * Restore link to sample annotation, but make it a permalink. --------- Co-authored-by: meredithslota <[email protected]> Co-authored-by: Chalmer Lowe <[email protected]> Co-authored-by: Victor Chudnovsky <[email protected]>

* chore: Use gapic-generator-python 0.65.0 PiperOrigin-RevId: 440970084 Source-Link: googleapis/googleapis@5e0a3d5 Source-Link: googleapis/googleapis-gen@b0c628a Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjBjNjI4YTNmYWRlNzY4ZjIyNWQ3Njk5Mjc5MWVhMWJhMmE4ODFiZSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

tseaver added do not merge Indicates a pull request not ready for merge, due to either quality or timing. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. api: storage Issues related to the Cloud Storage API. labels Nov 8, 2014

tseaver mentioned this pull request Nov 10, 2014

Fix #354: support slash in key names #364

Merged

tseaver mentioned this pull request Nov 11, 2014

Move 'bucket.BucketIterator' -> 'connection._BucketIterator'. #358

Merged

tseaver removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 11, 2014

dhermes reviewed Nov 11, 2014
View reviewed changes

gcloud/storage/bucket.py

"""

extra_params = {}

if prefix is not None:

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

tseaver added 5 commits November 11, 2014 19:07

Spurious parameter.

2d83943

More idiomatic use of '__iter__'.

b66a4f4

Add 'Bucket.iterator' method.

8436839

Exposes additional paramters for narrowing / batching key search. Fixes #26.

Capture 'prefixes' returned in iterator response.

9ab220d

Update TestStorageListFiles regression to use 'bucket.iterator'.

faf8595

See: #359 (comment)

tseaver added a commit that referenced this pull request Nov 12, 2014

Merge pull request #359 from tseaver/26-expose_bucket_iterator_w_extr…

cf0fca0

…a_params Fix #26: expose bucket iterator w extra params

tseaver merged commit cf0fca0 into googleapis:master Nov 12, 2014

tseaver deleted the 26-expose_bucket_iterator_w_extra_params branch November 12, 2014 00:30

parthea added a commit that referenced this pull request Sep 20, 2023

chore(deps): update all dependencies (#359)

d1dca20

Co-authored-by: Anthonios Partheniou <[email protected]>

parthea added a commit that referenced this pull request Sep 22, 2023

chore(deps): update dependency pytest to v7.4.0 (#359)

df1f68d

Co-authored-by: Anthonios Partheniou <[email protected]>

parthea added a commit that referenced this pull request Sep 22, 2023

chore(main): release 4.0.1 (#359)

ca3e4f5

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency pytest to v7.1.1 (#359)

388bdf4

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency pillow to v9.1.1 (#359)

8058213

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #26: expose bucket iterator w extra params #359

Fix #26: expose bucket iterator w extra params #359

tseaver commented Nov 8, 2014

coveralls commented Nov 8, 2014

coveralls commented Nov 10, 2014

coveralls commented Nov 10, 2014

dhermes commented Nov 10, 2014

tseaver commented Nov 10, 2014

dhermes commented Nov 11, 2014

coveralls commented Nov 11, 2014

tseaver commented Nov 11, 2014

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

dhermes commented Nov 11, 2014

tseaver commented Nov 11, 2014

coveralls commented Nov 12, 2014

tseaver commented Nov 12, 2014

coveralls commented Nov 12, 2014

Fix #26: expose bucket iterator w extra params #359

Fix #26: expose bucket iterator w extra params #359

Conversation

tseaver commented Nov 8, 2014

coveralls commented Nov 8, 2014

coveralls commented Nov 10, 2014

coveralls commented Nov 10, 2014

dhermes commented Nov 10, 2014

tseaver commented Nov 10, 2014

dhermes commented Nov 11, 2014

coveralls commented Nov 11, 2014

tseaver commented Nov 11, 2014

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

dhermes commented Nov 11, 2014

tseaver commented Nov 11, 2014

coveralls commented Nov 12, 2014

tseaver commented Nov 12, 2014

coveralls commented Nov 12, 2014