Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #324: Move ACL back-end manipulations from bucket / key to acl objects #326

Merged
merged 7 commits into from
Nov 3, 2014
Merged

Fix #324: Move ACL back-end manipulations from bucket / key to acl objects #326

merged 7 commits into from
Nov 3, 2014

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Oct 31, 2014

See #324.

@tseaver tseaver added do not merge Indicates a pull request not ready for merge, due to either quality or timing. api: storage Issues related to the Cloud Storage API. labels Oct 31, 2014
@tseaver
Copy link
Contributor Author

tseaver commented Oct 31, 2014

Presumes #318 is landed first.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 99b78b2 on tseaver:324-move_acl_manip_from_bucket_key_to_acl into 8e12e10 on GoogleCloudPlatform:master.

@dhermes
Copy link
Contributor

dhermes commented Oct 31, 2014

I'll hold off review until #318 lands. Please remind me if I forget.

@tseaver
Use ACL-specific endpoints where feasible for buckets.
18c1b25 
- Refactor lazy-handling of 'acl' and 'default_object_acl' using properties.

- Fetch 'ac' and 'defaultObjectAcl' via GET to specific endpoints.

- Continue to update 'acl' and 'defaultObjectAcl' via PATCH to the object's
  resource (we can't do incremental updates to ACEs).

Fixes #163.
@tseaver
Use ACL-specific endpoints where feasible for keys.
65d9962 
- Refactor lazy-handling of 'acl' using a property.

- Fetch 'acl' via GET to a specific endpoint.

- Continue to update 'acl' via PATCH to the object's resource (we can't do
  incremental updates to ACEs).

Fixes #151.
@tseaver
Fix save/clear ACL operations.
417333c 
Borked by dropping the 'projection' qs param to PATCH.  Docs spell
a default, but then note that overriding it w/ 'full' is required
(and we need 'full' anyway, because we expect to read the resulting
ACL back).
@tseaver
Move APIs for reload/save/clear ACLs onto ACL objects themselves.
9cfe627 
Fixes #324.
@tseaver tseaver removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 1, 2014
@tseaver
Copy link
Contributor Author

tseaver commented Nov 1, 2014

@dhermes Rebased after landing #318.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 9cfe627 on tseaver:324-move_acl_manip_from_bucket_key_to_acl into 632e126 on GoogleCloudPlatform:master.

dhermes
dhermes reviewed Nov 1, 2014
View reviewed changes
gcloud/storage/acl.py
:rtype: :class:`gcloud.storage.acl.BucketACL`
:returns: The current ACL.
"""
# We do things in this weird way because [] and None

This comment was marked as spam.

Sign in to view

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling bb9a3a8 on tseaver:324-move_acl_manip_from_bucket_key_to_acl into 632e126 on GoogleCloudPlatform:master.

@tseaver
Copy link
Contributor Author

tseaver commented Nov 3, 2014

@dhermes PTAL.

@dhermes
Copy link
Contributor

dhermes commented Nov 3, 2014

LGTM

I really wish GitHub would let us keep track of what we had already reviewed and then pick and choose which commits the left-hand and right-hand diffs are in the side-by-side view.

tseaver added a commit that referenced this pull request Nov 3, 2014
@tseaver
Merge pull request #326 from tseaver/324-move_acl_manip_from_bucket_k…
963d0dd 
…ey_to_acl

Fix #324: Move ACL back-end manipulations from bucket / key to acl objects
@tseaver tseaver merged commit 963d0dd into googleapis:master Nov 3, 2014
@tseaver tseaver deleted the 324-move_acl_manip_from_bucket_key_to_acl branch November 6, 2014 22:43
urshala pushed a commit to urshala/google-cloud-python that referenced this pull request Jan 17, 2020
logging resumable upload expiration datetime for debug googleapis#326
38700f6
atulep pushed a commit that referenced this pull request Apr 6, 2023
@renovate-bot @gcf-owl-bot @parthea
chore(deps): update all dependencies (#326)
4c8266f 
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
atulep pushed a commit that referenced this pull request Apr 6, 2023
@renovate-bot @gcf-owl-bot @parthea
chore(deps): update all dependencies (#326)
f7a57c4 
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
atulep pushed a commit that referenced this pull request Apr 18, 2023
@renovate-bot @gcf-owl-bot @parthea
chore(deps): update all dependencies (#326)
dfd2208 
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea pushed a commit that referenced this pull request Jun 4, 2023
@renovate-bot
chore(deps): update dependency google-auth to v2.16.0 (#326)
3d74264
parthea pushed a commit that referenced this pull request Jun 4, 2023
@gcf-owl-bot
chore(python): upgrade gcp-releasetool in .kokoro [autoapprove] (#326)
6d41ebe 
Source-Link: https://github.com/googleapis/synthtool/commit/5f2a6089f73abf06238fe4310f6a14d6f6d1eed3
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8555f0e37e6261408f792bfd6635102d2da5ad73f8f09bcb24f25e6afb5fac97
parthea pushed a commit that referenced this pull request Jun 4, 2023
@gcf-owl-bot
chore(python): use ubuntu 22.04 in docs image (#326)
b10d5cc 
Source-Link: googleapis/synthtool@f15cc72
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:bc5eed3804aec2f05fad42aacf973821d9500c174015341f721a984a0825b6fd
parthea pushed a commit that referenced this pull request Jun 4, 2023
@release-please
chore(main): release 2.12.1 (#326)
f2f69d1 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Jul 6, 2023
@release-please
chore(main): release 2.4.3 (#326)
e4edf40 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 20, 2023
@gcf-owl-bot
chore(python): exclude grpcio==1.49.0rc1 in tests [autoapprove] (#326)
d00309a 
Source-Link: googleapis/synthtool@c4dd595
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ce3c1686bc81145c81dd269bd12c4025c6b275b22d14641358827334fddb1d72
parthea pushed a commit that referenced this pull request Sep 20, 2023
@gcf-owl-bot
build(deps): [autoapprove] bump certifi from 2022.12.7 to 2023.7.22 (#…
7850ab7 
…326)

Source-Link: https://github.com/googleapis/synthtool/commit/395d53adeeacfca00b73abf197f65f3c17c8f1e9
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:6c1cbc75c74b8bdd71dada2fa1677e9d6d78a889e9a70ee75b93d1d0543f96e1
vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
@renovate-bot
chore(deps): update dependency google-cloud-dialogflow to v2.5.0 (#326)
d7313c2 
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [google-cloud-dialogflow](https://github.com/googleapis/dialogflow-python-client-v2) | `==2.4.0` -> `==2.5.0` | [![age](https://badges.renovateapi.com/packages/pypi/google-cloud-dialogflow/2.5.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/google-cloud-dialogflow/2.5.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/google-cloud-dialogflow/2.5.0/compatibility-slim/2.4.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/google-cloud-dialogflow/2.5.0/confidence-slim/2.4.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/dialogflow-python-client-v2</summary>

### [`v2.5.0`](https://github.com/googleapis/dialogflow-python-client-v2/blob/master/CHANGELOG.md#&#8203;250-httpswwwgithubcomgoogleapispython-dialogflowcomparev240v250-2021-06-26)

[Compare Source](https://github.com/googleapis/dialogflow-python-client-v2/compare/v2.4.0...v2.5.0)

##### Features

-   added Automated agent reply type and allow cancellation flag for partial response feature ([#&#8203;314](https://github.com/googleapis/python-dialogflow/issues/314)) ([5dfd375](https://github.com/googleapis/python-dialogflow/commit/5dfd375c389e41e8d87055a6479cfb9c0b5f2e37))
-   **v2beta1:** added Automated agent reply type and allow cancellation flag for partial response feature ([#&#8203;311](https://github.com/googleapis/python-dialogflow/issues/311)) ([1d34763](https://github.com/googleapis/python-dialogflow/commit/1d34763b13902162f567fac7768d08619f77f81e))

##### Documentation

-   added notes to train agent prior to sending queries ([#&#8203;319](https://github.com/googleapis/python-dialogflow/issues/319)) ([37dece2](https://github.com/googleapis/python-dialogflow/commit/37dece29c4f2b852f5d5426fb10c6c8b55d9bff6))
-   omit mention of Python 2.7 in 'CONTRIBUTING.rst' ([#&#8203;1127](https://github.com/googleapis/python-dialogflow/issues/1127)) ([#&#8203;316](https://github.com/googleapis/python-dialogflow/issues/316)) ([55fcb9d](https://github.com/googleapis/python-dialogflow/commit/55fcb9d366a27318e7f044f15984df8f3fb32f8e))
-   update comment in ListSuggestions to use absolute URL for /apis/design/design_patterns ([#&#8203;313](https://github.com/googleapis/python-dialogflow/issues/313)) ([99d8897](https://github.com/googleapis/python-dialogflow/commit/99d8897a9a576bcf1d3887c5d40ec86efd8e3ec4))

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/python-dialogflow).
parthea pushed a commit that referenced this pull request Sep 22, 2023
@renovate-bot
chore(deps): update dependency google-cloud-bigquery-connection to v1…
b364876 
….13.0 (#326)
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
chore(python): add nox session to sort python imports (#326)
bac8508 
Source-Link: googleapis/synthtool@1b71c10
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:00c9d764fd1cd56265f12a5ef4b99a0c9e87cf261018099141e2ca5158890416

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
chore(python): add support for python 3.11 (#326)
2fc2b6d 
Source-Link: googleapis/synthtool@7197a00
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:c43f1d918bcf817d337aa29ff833439494a158a0831508fda4ec75dc4c0d0320

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@release-please
chore(main): release 2.15.0 (#326)
2fe876f 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Sep 22, 2023
@renovate-bot @parthea
chore(deps): update dependency google-cloud-storage to v2 (#326)
48aaf55 
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea added a commit that referenced this pull request Sep 22, 2023
@release-please @parthea
chore(main): release 3.6.1 (#326)
0f8ef07 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@renovate-bot
chore(deps): update dependency pytest to v7.2.2 (#326)
f2b1d95
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
feat: Add support for python 3.11 (#326)
72f72ed 
* feat: Add support for python 3.11

chore: Update gapic-generator-python to v1.8.0
PiperOrigin-RevId: 500768693

Source-Link: googleapis/googleapis@190b612

Source-Link: googleapis/googleapis-gen@7bf29a4
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2JmMjlhNDE0YjllY2FjMzE3MGYwYjY1YmRjMmE5NTcwNWMwZWYxYSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Sep 22, 2023
@parthea
fix(deps): require protobuf <4.0.0dev (#326)
a7dce25
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore: use gapic-generator-python 1.3.1 (#326)
558d5b0 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 472772457

Source-Link: googleapis/googleapis@855b74d

Source-Link: googleapis/googleapis-gen@b64b1e7
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjY0YjFlN2RhM2UxMzhmMTVjYTM2MTU1MmVmMDU0NWU1NDg5MWI0ZiJ9
parthea pushed a commit that referenced this pull request Oct 21, 2023
@renovate-bot
chore(deps): update dependency google-cloud-kms to v2.12.1 (#326)
219332f
parthea added a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot @parthea
ci(python): run lint / unit tests / docs as GH actions (#326)
46d5dac 
* ci(python): run lint / unit tests / docs as GH actions

Source-Link: googleapis/synthtool@57be0cd
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ed1f9983d5a935a89fe8085e8bb97d94e41015252c5b6c9771257cf8624367e6

* add a commit to activate gh actions

* workaround bug in templates

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@renovate-bot
chore(deps): update dependency google-cloud-storage to v2.2.0 (#326)
cc732af
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
build(deps): bump cryptography from 38.0.3 to 39.0.1 in /synthtool/gc…
1748ba8 
…p/templates/python_library/.kokoro (#326)

Source-Link: https://github.com/googleapis/synthtool/commit/bb171351c3946d3c3c32e60f5f18cee8c464ec51
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f62c53736eccb0c4934a3ea9316e0d57696bb49c1a7c86c726e9bb8a2f87dadf
parthea added a commit that referenced this pull request Oct 21, 2023
@busunkim96 @parthea
chore: make samples 3.6 check optional (#326)
fc95b37 
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore: remove 'pip install' statements from python_library templates …
dcadc3c 
…[autoapprove] (#326)

Source-Link: googleapis/synthtool@1f37ce7
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8e84e0e0d71a0d681668461bba02c9e1394c785f31a10ae3470660235b673086
parthea added a commit that referenced this pull request Oct 22, 2023
@renovate-bot @gcf-owl-bot @parthea
chore(deps): update all dependencies (#326)
5d55b05 
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea added a commit that referenced this pull request Jan 10, 2025
@parthea
chore: remove pb2 file generation during post processing step (#326)
729f598
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @coveralls @dhermes