Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix packaging of tests and resources #3185

Merged
merged 18 commits into from
Mar 23, 2017
Merged

Fix packaging of tests and resources #3185

merged 18 commits into from
Mar 23, 2017

Conversation

theacodes
Copy link
Contributor

  • Don't include tests in the binary (wheel) distribution.
  • Include tests in the source distribution.
  • Include only .json and .proto package resources.
  • Include a LICENSE with every package (extremely important for downstream packagers).
    (From Fix packaging of resources and tests #3182)

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Mar 22, 2017
@theacodes
Copy link
Contributor Author

I need to rebase on top of ci, will do shortly.

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Mar 22, 2017
@theacodes
Copy link
Contributor Author

@lukesneeringer @dhermes rebased, should be good to review now.

@lukesneeringer
Copy link
Contributor

LGTM once I get ci in.

@theacodes
Copy link
Contributor Author

Since ci is already in review and this won't pass while targeting that branch, do we want to go ahead and merge this into ci?

@dhermes
Copy link
Contributor

dhermes commented Mar 22, 2017

👍 to what @jonparrott said

@lukesneeringer lukesneeringer merged commit a15be70 into ci Mar 23, 2017
@lukesneeringer lukesneeringer deleted the fix-packages branch March 23, 2017 14:25
@lukesneeringer
Copy link
Contributor

Yep, doing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants