Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Rehash #3146

Merged
merged 61 commits into from
Mar 23, 2017
Merged

CI Rehash #3146

merged 61 commits into from
Mar 23, 2017

Conversation

lukesneeringer
Copy link
Contributor

@lukesneeringer lukesneeringer commented Mar 15, 2017

This is a continuation of #3135. It is moved to google-cloud-python:ci (from my personal branch) because system tests do not run from personal branches.


This is an attempt to fix the CI situation on this repository. In particular, this will hit the following goals:

  • Move to parallel builds on a per-API basis. Superceded by not running unnecessary APIs.
  • Move system tests into the individual API packages.
  • Eliminate Travis, move CircleCI to 2.0

In doing this, I made several changes:

  • Move from tox to nox (Python-based configuration is really useful for the multi-project situation)
  • Move from pylint to flake8 (pylint does not work on Python 3.6, has multiple difficult-to-silence false positives)

This is not done. In particular, several things need to be put back into place:

  • Automatic docs build.
    • Note to self: Move docs into individual packages (not part of this PR).
  • Automatic PyPI releasing on appropriate tags.
  • Only testing APIs that have changed files.

@lukesneeringer lukesneeringer self-assigned this Mar 15, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 15, 2017
@tseaver tseaver added testing do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Mar 15, 2017
@tseaver
Copy link
Contributor

tseaver commented Mar 15, 2017

@lukesneeringer I tagged this one "do not merge" because you are still iterating rapidly.

@lukesneeringer
Copy link
Contributor Author

@lukesneeringer I tagged this one "do not merge" because you are still iterating rapidly.

Thank you!

@lukesneeringer
Copy link
Contributor Author

This should be almost ready. Because this commit moves literally everything, it triggers all the system tests now, so they need to pass before it is.

Once it is ready, I will rebase into a smaller number of commits so it is reviewable on a per-commit basis. Once approved, we will still squash. The rebase will be for review's sake.

@lukesneeringer
Copy link
Contributor Author

Hey @tseaver -- Do you happen to know off hand what this failure is about? Is it that the test (or backend) is flaky, or is there something else I should be investigating?

No need to do a ton of research; this is mostly a lazy if-you-know-off-the-top-of-your-head thing.

@tseaver
Copy link
Contributor

tseaver commented Mar 16, 2017

@lukesneeringer I'm not seeing the error detail show up on Circle CI today: just spinning arrows. I do have a pending Spaner flaky-unit-test fix (#3147), which I'm about to merge.

@lukesneeringer
Copy link
Contributor Author

lukesneeringer commented Mar 16, 2017

@tseaver This one is actually a system test; here is the failure:

REDACTED FOR EXCESSIVE LENGTH

@lukesneeringer
Copy link
Contributor Author

I now have CircleCI's build passing...sometimes. We have some system tests that are still flaky and we need to weed out. That said, this is probably close to ready, and still an improvement over where we were.

I will rebase tomorrow so that the PR is parse-able and reviewable.

@lukesneeringer
Copy link
Contributor Author

lukesneeringer commented Mar 17, 2017

Also, the total serial test run-time is down to 40 minutes. (I think I could implement some CircleCI caching of the virtualenvs to cut that in half.)

@lukesneeringer
Copy link
Contributor Author

Caught a new system test bug on merge; filed #3193

@lukesneeringer
Copy link
Contributor Author

lukesneeringer commented Mar 23, 2017

The previous build passed on AppVeyor; this one should pass now that #3193 is fixed. Assuming both pass without incident, will squash and merge.

Travis is failing because this build has no .travis.yml at all; after the merge, I will turn Travis completely off.

@lukesneeringer
Copy link
Contributor Author

lukesneeringer commented Mar 23, 2017

I finally have a green build. Squashing and merging.
I will then turn off Travis entirely.

@lukesneeringer lukesneeringer merged commit 030de07 into master Mar 23, 2017
@lukesneeringer lukesneeringer deleted the ci branch March 23, 2017 21:49
@dhermes
Copy link
Contributor

dhermes commented Mar 23, 2017

@lukesneeringer Why the merge without review?

@lukesneeringer
Copy link
Contributor Author

It has already gone through a non-trivial amount of review, by everyone here. The only "unreviewed" work was the AppVeyor thrashing.

@dhermes dhermes removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 31, 2017
@geigerj geigerj mentioned this pull request Apr 14, 2017
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@csilvers
Copy link
Contributor

csilvers commented Jul 6, 2017

It looks like CONTRIBUTING.rst still talks about running tox. Possibly other documentation does too. Can you fix it to show how to run tests in the new world? I can't figure out how to even install nox, much less run it.

@csilvers
Copy link
Contributor

csilvers commented Jul 6, 2017

Ah, I see, this is still open in #3205

tseaver pushed a commit that referenced this pull request Aug 1, 2019
Restore `index.yml` file removed in PR #3146.
atulep pushed a commit that referenced this pull request Apr 3, 2023
atulep pushed a commit that referenced this pull request Apr 18, 2023
parthea pushed a commit that referenced this pull request Jun 4, 2023
parthea pushed a commit that referenced this pull request Jul 6, 2023
parthea pushed a commit that referenced this pull request Oct 21, 2023
parthea pushed a commit that referenced this pull request Oct 21, 2023
parthea pushed a commit that referenced this pull request Oct 21, 2023
parthea pushed a commit that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants