Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update import spacing part 2. #2946

Merged
merged 2 commits into from
Jan 19, 2017

Conversation

daspecster
Copy link
Contributor

Part 2 of updating the rest of the spacing updates.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 18, 2017
@dhermes
Copy link
Contributor

dhermes commented Jan 18, 2017

Cursory LGTM

@daspecster
Copy link
Contributor Author

Too many lines for lint...

https://travis-ci.org/GoogleCloudPlatform/google-cloud-python/builds/193135431#L1461

I'll see what I can do. Maybe I can break up those modules.

@dhermes
Copy link
Contributor

dhermes commented Jan 18, 2017

Just increase the limit for tests in run_pylint.py?

@dhermes
Copy link
Contributor

dhermes commented Jan 19, 2017

Still LGTM

@daspecster daspecster merged commit 4f5f782 into googleapis:master Jan 19, 2017
@daspecster daspecster deleted the update-import-spacing-2 branch January 19, 2017 00:37
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
parthea pushed a commit that referenced this pull request Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants