Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Transcript to Alternative. #2666

Merged

Conversation

daspecster
Copy link
Contributor

Closer to #2522.

@daspecster daspecster added the api: speech Issues related to the Speech-to-Text API. label Nov 2, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 2, 2016
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM provide the few nits are resolved. Feel free to merge once fixed.

@@ -12,11 +12,11 @@
# See the License for the specific language governing permissions and
# limitations under the License.

"""Transcript representation for Google Speech API"""
"""Alternative representation for Google Speech API"""

This comment was marked as spam.

class Transcript(object):
"""Representation of Speech Transcripts.
class Alternative(object):
"""Representation of Speech Alternatives.

This comment was marked as spam.

@@ -15,41 +15,41 @@
import unittest


class TestTranscript(unittest.TestCase):
class AlternativeTests(unittest.TestCase):

This comment was marked as spam.

@@ -18,4 +18,4 @@
from google.cloud.speech.connection import Connection
from google.cloud.speech.encoding import Encoding
from google.cloud.speech.operation import Operation
from google.cloud.speech.transcript import Transcript
from google.cloud.speech.alternative import Alternative

This comment was marked as spam.

@daspecster daspecster force-pushed the rename-transcript-to-alternative branch from fabb14c to 05e7eb6 Compare November 2, 2016 03:57
@daspecster
Copy link
Contributor Author

Updated and squashed.

@daspecster daspecster merged commit 6c59755 into googleapis:master Nov 2, 2016
@daspecster daspecster mentioned this pull request Nov 10, 2016
14 tasks
@daspecster daspecster deleted the rename-transcript-to-alternative branch January 24, 2017 15:17
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
…to-alternative

Rename Transcript to Alternative.
atulep pushed a commit that referenced this pull request Apr 3, 2023
atulep pushed a commit that referenced this pull request Apr 18, 2023
parthea pushed a commit that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: speech Issues related to the Speech-to-Text API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants