-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Transcript to Alternative. #2666
Rename Transcript to Alternative. #2666
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM provide the few nits are resolved. Feel free to merge once fixed.
@@ -12,11 +12,11 @@ | |||
# See the License for the specific language governing permissions and | |||
# limitations under the License. | |||
|
|||
"""Transcript representation for Google Speech API""" | |||
"""Alternative representation for Google Speech API""" |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
class Transcript(object): | ||
"""Representation of Speech Transcripts. | ||
class Alternative(object): | ||
"""Representation of Speech Alternatives. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@@ -15,41 +15,41 @@ | |||
import unittest | |||
|
|||
|
|||
class TestTranscript(unittest.TestCase): | |||
class AlternativeTests(unittest.TestCase): |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@@ -18,4 +18,4 @@ | |||
from google.cloud.speech.connection import Connection | |||
from google.cloud.speech.encoding import Encoding | |||
from google.cloud.speech.operation import Operation | |||
from google.cloud.speech.transcript import Transcript | |||
from google.cloud.speech.alternative import Alternative |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
fabb14c
to
05e7eb6
Compare
Updated and squashed. |
…to-alternative Rename Transcript to Alternative.
…tive Rename Transcript to Alternative.
…tive Rename Transcript to Alternative.
…tive Rename Transcript to Alternative.
Closer to #2522.