Normalize gax support #2124
Merged
Normalize gax support #2124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| def _mon_resource_pb_to_mapping(resource_pb): | ||
| """Helper for :func:_log_entry_pb_to_mapping""" | ||
| """Helper for :func:_log_entry_pb_to_mapping | ||
| """ |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@tseaver What inspired this hygienic PR? |
They used to add value, but as the GAX API surface evolved, they are just cruft.
- Move '_pb_timestamp_to_rfc3339' to '_helpers' (where other datetime utils live). - Update comments for helpers which map protobuf attrs to / from JSON mappings: because the names change (camelCase vs. with_underlines), the wished-for protobuf helper function would be inadequate.
|
LGTM. |
dhermes
added a commit
to dhermes/google-cloud-python
that referenced
this pull request
Aug 19, 2016
Introduced in googleapis#2124. Fixes googleapis#2140.
Merged
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.