Regenerate from final Bigtable v2 v2 protos #1925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tseaver
added
api: datastore
googlebot
added
the
cla: yes
This was referenced Jun 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1918.
In order to make the generation process repeatable, I updated the makefiles to create a virtualenv and install the latest
grpcio/grpcio-tools: the latter can then be used to generate gRPC-aware stubs from protos, without relying on any otherprotoccompiler.Note that I don't actually update the generated code for
datastoreorbigtableV1 protos: although they do generate cleanly, examinig the diffs closely is off my radar for now.