Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable GAX bundling for 'Topic.publish'. #1910

Merged
merged 2 commits into from
Jun 27, 2016
Merged

Disable GAX bundling for 'Topic.publish'. #1910

merged 2 commits into from
Jun 27, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jun 26, 2016

Closes #1869.

Works around googleapis/gax-python#113.

/cc @bjwatson, @geigerj

@tseaver tseaver added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: pubsub Issues related to the Pub/Sub API. labels Jun 26, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 26, 2016
@tseaver
Copy link
Contributor Author

tseaver commented Jun 27, 2016

@bjwatson, @geigerj with this change, the Pubsub system tests all pass. We still have the hang-at-end, due to grpc/grpc#6857 .

@daspecster
Copy link
Contributor

LGTM

@tseaver tseaver merged commit 5ac80ba into googleapis:master Jun 27, 2016
@tseaver tseaver deleted the 1869-pubsub-disable_gax_bundling_for_publish branch June 27, 2016 15:03
@tseaver tseaver mentioned this pull request Jun 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants