Add monitoring client #1442
Closed
Add monitoring client #1442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
I realize we have a bug in our imports (lines 35 and 37 of metric_service_api.py are syntax errors). I will fix the imports and update the PR. |
|
I've updated the PR -- ready for code review now. |
|
Thanks for the heads up. Reviewing now. |
| from google.gax import config | ||
| from google.gax.path_template import PathTemplate | ||
| from google.monitoring.v3 import agent_service_pb2 | ||
| from google.api import monitored_resource_pb2 |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Finished review |
|
Did you mean to close? |
parthea
pushed a commit
that referenced
this pull request
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds generated code wrapping the gRPC monitoring library, similar to the previous PR for logging.
We have addressed some of the issues raised in the logging PR; those that have not been addressed are being tracked. We expect to have a proper github repo in the next day or so where we will be able to track those issues publicly.