feat: add support for field generate_omitted_as_internal in selective gapic generation #13482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcf-owl-bot[bot]](https://avatars.githubusercontent.com/in/99011?s=60&v=4){kind=small}
trusted-contributions-gcf
bot
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
trusted-contributions-gcf
bot
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
vchudnov-g
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
trusted-contributions-gcf
bot
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
|
Owl bot is regenerating pull request 13482... |
gcf-owl-bot
bot
force-pushed
the
owl-bot-copy-packages-googleapis-common-protos
branch
from
21e0b53 to
3121cc1
Compare
trusted-contributions-gcf
bot
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
trusted-contributions-gcf
bot
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
vchudnov-g
added
the
do not merge
|
The @parthea Any insights? |
trusted-contributions-gcf
bot
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
|
OK, the removal of the license headers in the protoc-generated files is fine according to the internal policy in go/releasing/preparing#license-headers, |
vchudnov-g
added
do not merge
|
Blocking again since the internal go/cross tool complains on the lack of license headers. |
|
Owl bot is regenerating pull request 13482... |
… gapic generation PiperOrigin-RevId: 721375937 Source-Link: googleapis/googleapis@78733bf Source-Link: googleapis/googleapis-gen@a1335fa Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlYXBpcy1jb21tb24tcHJvdG9zLy5Pd2xCb3QueWFtbCIsImgiOiJhMTMzNWZhOTQ2Mzk5NzlhMzgzMWUwNjAzNWFhYzQ0YTI0ZmRhY2M0In0=
gcf-owl-bot
bot
force-pushed
the
owl-bot-copy-packages-googleapis-common-protos
branch
from
7234c78 to
e0bb957
Compare
trusted-contributions-gcf
bot
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
trusted-contributions-gcf
bot
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
parthea
removed
the
do not merge
parthea
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PiperOrigin-RevId: 721375937
Source-Link: googleapis/googleapis@78733bf
Source-Link: https://github.com/googleapis/googleapis-gen/commit/a1335fa94639979a3831e06035aac44a24fdacc4
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlYXBpcy1jb21tb24tcHJvdG9zLy5Pd2xCb3QueWFtbCIsImgiOiJhMTMzNWZhOTQ2Mzk5NzlhMzgzMWUwNjAzNWFhYzQ0YTI0ZmRhY2M0In0=