chore: update script for generating README #12689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parthea
changed the title
vchudnov-g
reviewed
May 13, 2024
vchudnov-g
reviewed
May 13, 2024
vchudnov-g
reviewed
May 14, 2024
There was a problem hiding this comment.
Wanted to expand on a point: the Extractor is either a data class that does not care whether it's a split repo or not (it just blindly uses the values decided upon and given by its caller); or it's a regular class and it decides and sets those values internally. We shouldn't mix the two models, IMO.
parthea
reviewed
May 14, 2024
parthea
approved these changes
May 14, 2024
vchudnov-g
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #11147
Towards #12679 🦕