Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add the SheetExportAudienceList method to the Data API v1 alpha #12006

Merged

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Nov 8, 2023

  • Regenerate this pull request now.

BEGIN_COMMIT_OVERRIDE
feat: add the SheetExportAudienceList method to the Data API v1 alpha
feat: add creation_quota_tokens_charged, row_count, error_message to the AudienceList resource
fix: add optional annotation to the page_token field of the ListAudienceListsRequest type
fix: add optional annotation to the offset, limit fields of the QueryAudienceListRequest type
fix: add required annotation to the name field of the QueryAudienceListRequest type
fix: add optional annotation to the dimension_name field of the AudienceDimension type
fix: add optional annotation to the property, date_ranges, funnel, funnel_breakdown, funnel_visualization_type, segments, dimension_filter, return_property_quota, limit fields of the RunFunnelReportRequest type
fix!: change the resource pattern value to properties/{property}/audienceLists/{audience_list} for the resource definition analyticsdata.googleapis.com/AudienceList
fix!: change the resource pattern value to properties/{property} for the resource definition analyticsadmin.googleapis.com/Property
END_COMMIT_OVERRIDE

feat: add creation_quota_tokens_charged, row_count, error_message to the AudienceList resource
fix: add optional annotation to the page_token field of the ListAudienceListsRequest type
fix: add optional annotation to the offset, limit fields of the QueryAudienceListRequest type
fix: add required annotation to the name field of the QueryAudienceListRequest type
fix: add optional annotation to the dimension_name field of the AudienceDimension type
fix: add optional annotation to the property, date_ranges, funnel, funnel_breakdown, funnel_visualization_type, segments, dimension_filter, return_property_quota, limit fields of the RunFunnelReportRequest type
fix!: change the resource pattern value to properties/{property}/audienceLists/{audience_list} for the resource definition analyticsdata.googleapis.com/AudienceList
fix!: change the resource pattern value to properties/{property} for the resource definition analyticsadmin.googleapis.com/Property

PiperOrigin-RevId: 580634757

Source-Link: googleapis/googleapis@a50eda1

Source-Link: https://github.com/googleapis/googleapis-gen/commit/e55c7e473524e3df4332609aa22963180eba1c01
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWFuYWx5dGljcy1kYXRhLy5Pd2xCb3QueWFtbCIsImgiOiJlNTVjN2U0NzM1MjRlM2RmNDMzMjYwOWFhMjI5NjMxODBlYmExYzAxIn0=

feat: add `creation_quota_tokens_charged`, `row_count`, `error_message` to the `AudienceList` resource
fix: add `optional` annotation to the `page_token` field of the `ListAudienceListsRequest` type
fix: add `optional` annotation to the `offset`, `limit` fields of the `QueryAudienceListRequest` type
fix: add `required` annotation to the `name` field of the `QueryAudienceListRequest` type
fix: add `optional` annotation to the `dimension_name` field of the `AudienceDimension` type
fix: add `optional` annotation to the `property`, `date_ranges`, `funnel`, `funnel_breakdown`, `funnel_visualization_type`, `segments`, `dimension_filter`, `return_property_quota`, `limit` fields of the `RunFunnelReportRequest` type
fix!: change the resource pattern value to `properties/{property}/audienceLists/{audience_list}` for the resource definition `analyticsdata.googleapis.com/AudienceList`
fix!: change the resource pattern value to `properties/{property}` for the resource definition `analyticsadmin.googleapis.com/Property`

PiperOrigin-RevId: 580634757

Source-Link: googleapis/googleapis@a50eda1

Source-Link: googleapis/googleapis-gen@e55c7e4
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWFuYWx5dGljcy1kYXRhLy5Pd2xCb3QueWFtbCIsImgiOiJlNTVjN2U0NzM1MjRlM2RmNDMzMjYwOWFhMjI5NjMxODBlYmExYzAxIn0=
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 8, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 8, 2023
@gcf-owl-bot gcf-owl-bot bot marked this pull request as ready for review November 8, 2023 22:54
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner November 8, 2023 22:54
Copy link

snippet-bot bot commented Nov 8, 2023

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 8, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 8, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 9, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 9, 2023
propertyId: str,
audienceListId: str,
property: str,
audience_list: str,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like this is a braking change, since the name of the parameter changed, and parameters can be named by the caller.

This is an alpha API so having the breaking change is fine, but we should flag it. And we should tweak our process so it gets flagged upstream.

@vchudnov-g vchudnov-g added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 9, 2023
@vchudnov-g
Copy link
Contributor

Marking as "do not merge" until we flag the breaking change.

@vchudnov-g vchudnov-g removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 9, 2023
Copy link
Contributor

@vchudnov-g vchudnov-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, the breaking change is indeed flagged with !, so we can proceed.

@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 9, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 9, 2023
@vchudnov-g vchudnov-g added the automerge Merge the pull request once unit tests and other checks pass. label Nov 9, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit c28986d into main Nov 9, 2023
@gcf-merge-on-green gcf-merge-on-green bot deleted the owl-bot-copy-packages-google-analytics-data branch November 9, 2023 20:32
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kokoro:force-run Add this label to force Kokoro to re-run the tests. owl-bot-copy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant