-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add the SheetExportAudienceList
method to the Data API v1 alpha
#12006
feat: add the SheetExportAudienceList
method to the Data API v1 alpha
#12006
Conversation
feat: add `creation_quota_tokens_charged`, `row_count`, `error_message` to the `AudienceList` resource fix: add `optional` annotation to the `page_token` field of the `ListAudienceListsRequest` type fix: add `optional` annotation to the `offset`, `limit` fields of the `QueryAudienceListRequest` type fix: add `required` annotation to the `name` field of the `QueryAudienceListRequest` type fix: add `optional` annotation to the `dimension_name` field of the `AudienceDimension` type fix: add `optional` annotation to the `property`, `date_ranges`, `funnel`, `funnel_breakdown`, `funnel_visualization_type`, `segments`, `dimension_filter`, `return_property_quota`, `limit` fields of the `RunFunnelReportRequest` type fix!: change the resource pattern value to `properties/{property}/audienceLists/{audience_list}` for the resource definition `analyticsdata.googleapis.com/AudienceList` fix!: change the resource pattern value to `properties/{property}` for the resource definition `analyticsadmin.googleapis.com/Property` PiperOrigin-RevId: 580634757 Source-Link: googleapis/googleapis@a50eda1 Source-Link: googleapis/googleapis-gen@e55c7e4 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWFuYWx5dGljcy1kYXRhLy5Pd2xCb3QueWFtbCIsImgiOiJlNTVjN2U0NzM1MjRlM2RmNDMzMjYwOWFhMjI5NjMxODBlYmExYzAxIn0=
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
propertyId: str, | ||
audienceListId: str, | ||
property: str, | ||
audience_list: str, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like this is a braking change, since the name of the parameter changed, and parameters can be named by the caller.
This is an alpha API so having the breaking change is fine, but we should flag it. And we should tweak our process so it gets flagged upstream.
Marking as "do not merge" until we flag the breaking change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, the breaking change is indeed flagged with !
, so we can proceed.
BEGIN_COMMIT_OVERRIDE
feat: add the SheetExportAudienceList method to the Data API v1 alpha
feat: add
creation_quota_tokens_charged
,row_count
,error_message
to theAudienceList
resourcefix: add
optional
annotation to thepage_token
field of theListAudienceListsRequest
typefix: add
optional
annotation to theoffset
,limit
fields of theQueryAudienceListRequest
typefix: add
required
annotation to thename
field of theQueryAudienceListRequest
typefix: add
optional
annotation to thedimension_name
field of theAudienceDimension
typefix: add
optional
annotation to theproperty
,date_ranges
,funnel
,funnel_breakdown
,funnel_visualization_type
,segments
,dimension_filter
,return_property_quota
,limit
fields of theRunFunnelReportRequest
typefix!: change the resource pattern value to
properties/{property}/audienceLists/{audience_list}
for the resource definitionanalyticsdata.googleapis.com/AudienceList
fix!: change the resource pattern value to
properties/{property}
for the resource definitionanalyticsadmin.googleapis.com/Property
END_COMMIT_OVERRIDE
feat: add
creation_quota_tokens_charged
,row_count
,error_message
to theAudienceList
resourcefix: add
optional
annotation to thepage_token
field of theListAudienceListsRequest
typefix: add
optional
annotation to theoffset
,limit
fields of theQueryAudienceListRequest
typefix: add
required
annotation to thename
field of theQueryAudienceListRequest
typefix: add
optional
annotation to thedimension_name
field of theAudienceDimension
typefix: add
optional
annotation to theproperty
,date_ranges
,funnel
,funnel_breakdown
,funnel_visualization_type
,segments
,dimension_filter
,return_property_quota
,limit
fields of theRunFunnelReportRequest
typefix!: change the resource pattern value to
properties/{property}/audienceLists/{audience_list}
for the resource definitionanalyticsdata.googleapis.com/AudienceList
fix!: change the resource pattern value to
properties/{property}
for the resource definitionanalyticsadmin.googleapis.com/Property
PiperOrigin-RevId: 580634757
Source-Link: googleapis/googleapis@a50eda1
Source-Link: https://github.com/googleapis/googleapis-gen/commit/e55c7e473524e3df4332609aa22963180eba1c01
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWFuYWx5dGljcy1kYXRhLy5Pd2xCb3QueWFtbCIsImgiOiJlNTVjN2U0NzM1MjRlM2RmNDMzMjYwOWFhMjI5NjMxODBlYmExYzAxIn0=