Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for resource record sets #1144

Merged
merged 4 commits into from
Sep 21, 2015
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add 'ResourceRecordSet' class.
  • Loading branch information
tseaver committed Sep 21, 2015
commit 90c9aadf554b89cf058735d3e322bc5b0c834281
67 changes: 67 additions & 0 deletions gcloud/dns/resource_record_set.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
# Copyright 2015 Google Inc. All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

"""Define API ResourceRecordSets."""


class ResourceRecordSet(object):
"""ResourceRecordSets are DNS resource records.

RRS are contained wihin a :class:`gcloud.dns.zone.ManagedZone` instance.

See:
https://cloud.google.com/dns/api/v1/resourceRecordSets

:type name: string
:param name: the name of the record set

:type record_type: string
:param record_type: the RR type of the zone

:type ttl: integer
:param ttl: TTL (in seconds) for caching the record sets

:type rrdatas: list of string
:param rrdatas: one or more lines containing the resource data

:type zone: :class:`gcloud.dns.zone.ManagedZone`
:param zone: A zone which holds one or more record sets.
"""

def __init__(self, name, record_type, ttl, rrdatas, zone):
self.name = name
self.record_type = record_type
self.ttl = ttl
self.rrdatas = rrdatas
self.zone = zone

@classmethod
def from_api_repr(cls, resource, zone):
"""Factory: construct a zone given its API representation

:type resource: dict
:param resource: zone resource representation returned from the API


:type zone: :class:`gcloud.dns.zone.ManagedZone`
:param zone: A zone which holds one or more record sets.

:rtype: :class:`gcloud.dns.zone.ResourceRecordSets`
:returns: RRS parsed from ``resource``.
"""
name = resource['name']
record_type = resource['type']
ttl = int(resource['ttl'])
rrdatas = resource['rrdatas']

This comment was marked as spam.

This comment was marked as spam.

return cls(name, record_type, ttl, rrdatas, zone=zone)
94 changes: 94 additions & 0 deletions gcloud/dns/test_resource_record_set.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,94 @@
# Copyright 2015 Google Inc. All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

import unittest2


class TestResourceRecordSet(unittest2.TestCase):

def _getTargetClass(self):
from gcloud.dns.resource_record_set import ResourceRecordSet
return ResourceRecordSet

def _makeOne(self, *args, **kw):
return self._getTargetClass()(*args, **kw)

def test_ctor(self):
zone = _Zone()

rrs = self._makeOne('test.example.com', 'CNAME', 3600,
['www.example.com'], zone)

self.assertEqual(rrs.name, 'test.example.com')
self.assertEqual(rrs.record_type, 'CNAME')
self.assertEqual(rrs.ttl, 3600)
self.assertEqual(rrs.rrdatas, ['www.example.com'])
self.assertTrue(rrs.zone is zone)

def test_from_api_repr_missing_rrdatas(self):
zone = _Zone()
klass = self._getTargetClass()

with self.assertRaises(KeyError):
klass.from_api_repr({'name': 'test.example.com',
'type': 'CNAME',
'ttl': 3600}, zone=zone)

def test_from_api_repr_missing_ttl(self):
zone = _Zone()
klass = self._getTargetClass()

with self.assertRaises(KeyError):
klass.from_api_repr({'name': 'test.example.com',
'type': 'CNAME',
'rrdatas': ['www.example.com']}, zone=zone)

def test_from_api_repr_missing_type(self):
zone = _Zone()
klass = self._getTargetClass()

with self.assertRaises(KeyError):
klass.from_api_repr({'name': 'test.example.com',
'ttl': 3600,
'rrdatas': ['www.example.com']}, zone=zone)

def test_from_api_repr_missing_name(self):
zone = _Zone()
klass = self._getTargetClass()

with self.assertRaises(KeyError):
klass.from_api_repr({'type': 'CNAME',
'ttl': 3600,
'rrdatas': ['www.example.com']}, zone=zone)

def test_from_api_repr_bare(self):
zone = _Zone()
RESOURCE = {
'kind': 'dns#resourceRecordSet',
'name': 'test.example.com',
'type': 'CNAME',
'ttl': '3600',
'rrdatas': ['www.example.com'],
}
klass = self._getTargetClass()
rrs = klass.from_api_repr(RESOURCE, zone=zone)
self.assertEqual(rrs.name, 'test.example.com')
self.assertEqual(rrs.record_type, 'CNAME')
self.assertEqual(rrs.ttl, 3600)
self.assertEqual(rrs.rrdatas, ['www.example.com'])
self.assertTrue(rrs.zone is zone)


class _Zone(object):
pass