Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing resource manager API #1083

Merged
merged 14 commits into from
Aug 27, 2015
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Implementing _ProjectIterator in resource_manager.
  • Loading branch information
dhermes committed Aug 27, 2015
commit a91512e32ceeb411b8415cdc36887057b7b9cf4e
30 changes: 30 additions & 0 deletions gcloud/resource_manager/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@


from gcloud.client import Client as BaseClient
from gcloud.iterator import Iterator
from gcloud.resource_manager.connection import Connection
from gcloud.resource_manager.project import Project

Expand Down Expand Up @@ -73,3 +74,32 @@ def project(self, project_id, name=None, labels=None):
"""
return Project(project_id=project_id,
client=self, name=name, labels=labels)


class _ProjectIterator(Iterator):
"""An iterator over a list of Project resources.

You shouldn't have to use this directly, but instead should use the
helper methods on :class:`gcloud.resource_manager.client.Client`
objects.

:type client: :class:`gcloud.resource_manager.client.Client`
:param client: The client to use for making connections.

:type extra_params: dict or :data:`NoneType <types.NoneType>`
:param extra_params: Extra query string parameters for the API call.
"""

def __init__(self, client, extra_params=None):
super(_ProjectIterator, self).__init__(client=client, path='/projects',
extra_params=extra_params)

def get_items_from_response(self, response):
"""Yield :class:`.Project` items from response.

:type response: dict
:param response: The JSON API response for a page of projects.
"""
for resource in response.get('projects', []):
item = Project.from_api_repr(resource, client=self.client)
yield item
54 changes: 54 additions & 0 deletions gcloud/resource_manager/test_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,60 @@
import unittest2


class Test__ProjectIterator(unittest2.TestCase):

def _getTargetClass(self):
from gcloud.resource_manager.client import _ProjectIterator
return _ProjectIterator

def _makeOne(self, *args, **kw):
return self._getTargetClass()(*args, **kw)

def test_constructor(self):
client = object()
iterator = self._makeOne(client)
self.assertEqual(iterator.path, '/projects')
self.assertEqual(iterator.page_number, 0)
self.assertEqual(iterator.next_page_token, None)
self.assertTrue(iterator.client is client)
self.assertEqual(iterator.extra_params, {})

def test_get_items_from_response_empty(self):
client = object()
iterator = self._makeOne(client)
self.assertEqual(list(iterator.get_items_from_response({})), [])

def test_get_items_from_response_non_empty(self):
from gcloud.resource_manager.project import Project

PROJECT_ID = 'project-id'
PROJECT_NAME = 'My Project Name'
PROJECT_NUMBER = 12345678
PROJECT_LABELS = {'env': 'prod'}
PROJECT_LIFECYCLE_STATE = 'ACTIVE'
API_RESOURCE = {
'projectId': PROJECT_ID,
'name': PROJECT_NAME,
'projectNumber': PROJECT_NUMBER,
'labels': PROJECT_LABELS,
'lifecycleState': PROJECT_LIFECYCLE_STATE,
}
RESPONSE = {'projects': [API_RESOURCE]}

client = object()
iterator = self._makeOne(client)
projects = list(iterator.get_items_from_response(RESPONSE))

project, = projects
self.assertTrue(isinstance(project, Project))
self.assertEqual(project.project_id, PROJECT_ID)
self.assertEqual(project._client, client)
self.assertEqual(project.name, PROJECT_NAME)
self.assertEqual(project.number, PROJECT_NUMBER)
self.assertEqual(project.labels, PROJECT_LABELS)
self.assertEqual(project.status, PROJECT_LIFECYCLE_STATE)


class TestClient(unittest2.TestCase):

def _getTargetClass(self):
Expand Down